Skip to content

Commit ee9796b

Browse files
committed
Turn some debug logs into trace logs
These messages are very verbose and I don't think they bring a lot of utility. The "worker challenge" log was misleading, because it was also printed for client connections.
1 parent d4f3c25 commit ee9796b

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

crates/tako/src/internal/server/rpc.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ async fn worker_rpc_loop(
122122
);
123123

124124
let heartbeat_interval = msg.configuration.heartbeat_interval;
125-
log::debug!("Worker heartbeat: {heartbeat_interval:?}");
125+
log::debug!("Worker heartbeat interval: {heartbeat_interval:?}");
126126
// Sanity that interval is not too small
127127
assert!(heartbeat_interval.as_millis() > 150);
128128

@@ -318,7 +318,7 @@ pub(crate) async fn worker_receive_loop<
318318
}
319319
FromWorkerMessage::Heartbeat => {
320320
if let Some(worker) = core.get_worker_mut(worker_id) {
321-
log::debug!("Heartbeat received, worker={worker_id}");
321+
log::trace!("Heartbeat received, worker={worker_id}");
322322
worker.last_heartbeat = Instant::now();
323323
};
324324
}

crates/tako/src/internal/transfer/auth.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ impl Authenticator {
9797
match &mut (message.mode, &self.secret_key) {
9898
(AuthenticationMode::NoAuth, None) => Ok(AuthenticationResponse::NoAuth),
9999
(AuthenticationMode::Encryption(msg), Some(key)) => {
100-
log::debug!("Worker authorization started");
100+
log::trace!("Peer authorization started");
101101
if msg.challenge.len() != CHALLENGE_LENGTH {
102102
return self._make_error(format!(
103103
"Invalid length of challenge ({})",
@@ -144,11 +144,11 @@ impl Authenticator {
144144
return Err(format!("Received authentication error: {}", error.message).into());
145145
}
146146
(AuthenticationResponse::NoAuth, None) => {
147-
log::debug!("Empty authentication finished");
147+
log::trace!("Empty authentication finished");
148148
None
149149
}
150150
(AuthenticationResponse::Encryption(response), Some(key)) => {
151-
log::debug!("Challenge verification started");
151+
log::trace!("Challenge verification started");
152152
let remote_nonce =
153153
&Nonce::from_slice(&response.nonce).map_err(|_| "Invalid nonce")?;
154154
let mut opener =
@@ -164,7 +164,7 @@ impl Authenticator {
164164
if tag != StreamTag::Message || opened_challenge != expected_response {
165165
return Err("Received challenge does not match.".into());
166166
}
167-
log::debug!("Challenge verification finished");
167+
log::trace!("Challenge verification finished");
168168
Some(opener)
169169
}
170170
(_, _) => {

0 commit comments

Comments
 (0)