Fix Clippy

Author: Kobzol

crates/hyperqueue/src/client/commands/submit/directives.rs

@@ -19,7 +19,7 @@ use crate::common::utils::fs::read_at_most;
 
 const MAX_PREFIX_OF_SUBMIT_SCRIPT: usize = 32 * 1024; // 32KiB
 
-fn p_double_quoted(input: &str) -> NomResult<&str> {
+fn p_double_quoted(input: &str) -> NomResult<'_, &str> {
     preceded(
         char('"'),
         cut(terminated(
@@ -29,7 +29,7 @@ fn p_double_quoted(input: &str) -> NomResult<&str> {
     )(input)
 }
 
-fn p_arg(input: &str) -> NomResult<String> {
+fn p_arg(input: &str) -> NomResult<'_, String> {
     alt((
         map(p_double_quoted, |s| s.to_string()),
         map(

crates/hyperqueue/src/client/output/cli.rs

@@ -1,6 +1,5 @@
 use cli_table::format::{Justify, Separator};
 use cli_table::{Cell, CellStruct, Color, ColorChoice, Style, Table, TableStruct, print_stdout};
-use itertools::Itertools;
 
 use std::fmt::{Display, Write};
 

crates/hyperqueue/src/common/parser.rs

@@ -215,7 +215,7 @@ where
     map_parse_result(all_consuming(f)(input).map(|r| r.1), input)
 }
 
-fn p_integer_string(input: &str) -> NomResult<String> {
+fn p_integer_string(input: &str) -> NomResult<'_, String> {
     let parser = tuple((
         satisfy(|c| c.is_dec_digit()),
         many0(satisfy(|c| c.is_dec_digit() || c == '_')),
@@ -228,14 +228,14 @@ fn p_integer_string(input: &str) -> NomResult<String> {
 }
 
 /// Parse 4 byte integer.
-pub fn p_u32(input: &str) -> NomResult<u32> {
+pub fn p_u32(input: &str) -> NomResult<'_, u32> {
     map_res(p_integer_string, |number| number.parse())
         .context(CONTEXT_INTEGER)
         .parse(input)
 }
 
 /// Parse 8 byte integer
-pub fn p_u64(input: &str) -> NomResult<u64> {
+pub fn p_u64(input: &str) -> NomResult<'_, u64> {
     map_res(p_integer_string, |number| number.parse())
         .context(CONTEXT_INTEGER)
         .parse(input)

crates/hyperqueue/src/common/placeholders.rs

@@ -190,7 +190,7 @@ pub enum StringPart<'a> {
     Placeholder(&'a str),
 }
 
-fn parse_placeholder(data: &str) -> NomResult<&str> {
+fn parse_placeholder(data: &str) -> NomResult<'_, &str> {
     delimited(tag("%{"), take_until("}"), tag("}"))(data)
 }
 
@@ -216,7 +216,7 @@ pub fn has_placeholders(data: &str) -> bool {
 ///     StringPart::Verbatim("c"),
 /// ]);
 /// ```
-pub fn parse_resolvable_string(data: &str) -> Vec<StringPart> {
+pub fn parse_resolvable_string(data: &str) -> Vec<StringPart<'_>> {
     let mut parts = vec![];
     let mut input = data;
     let mut start = 0;

crates/hyperqueue/src/common/utils/str.rs

@@ -1,7 +1,7 @@
 use std::borrow::Cow;
 
 /// Return the input string with an added "s" at the end if `count` is larger than one and non-zero.
-pub fn pluralize(value: &str, count: usize) -> Cow<str> {
+pub fn pluralize(value: &str, count: usize) -> Cow<'_, str> {
     if count == 1 {
         Cow::Borrowed(value)
     } else {
@@ -21,7 +21,7 @@ pub fn select_plural<'a>(single: &'a str, other: &'a str, count: usize) -> Cow<'
 /// Truncates the middle of a string so that it's total length doesn't exceed `length`.
 /// The returned string will never exceed `length`.
 /// `length` has to be at least five, otherwise there wouldn't be space for `...`.
-pub fn truncate_middle(value: &str, length: usize) -> Cow<str> {
+pub fn truncate_middle(value: &str, length: usize) -> Cow<'_, str> {
     assert!(length >= 5);
 
     if value.len() <= length {

crates/hyperqueue/src/dashboard/ui/styles.rs

@@ -35,7 +35,7 @@ pub fn table_block_with_title(title: Line) -> Block {
         .title(title)
 }
 
-pub fn style_column_headers(cells: Vec<&str>) -> Row {
+pub fn style_column_headers(cells: Vec<&str>) -> Row<'_> {
     Row::new(cells).style(
         Style::default()
             .fg(Color::Yellow)

crates/hyperqueue/src/stream/reader/outputlog.rs

@@ -211,7 +211,7 @@ impl OutputLog {
         Ok(index)
     }
 
-    fn check_header(file: &mut BufReader<File>) -> anyhow::Result<StreamFileHeader> {
+    fn check_header(file: &mut BufReader<File>) -> anyhow::Result<StreamFileHeader<'_>> {
         let mut header = [0u8; STREAM_FILE_HEADER.len()];
         file.read_exact(&mut header)?;
         if header != STREAM_FILE_HEADER {

crates/hyperqueue/src/worker/hwdetect.rs

@@ -248,7 +248,7 @@ fn read_linux_thread_siblings(cpu_id: &ResourceLabel) -> anyhow::Result<Vec<Reso
         .map(|indices| indices.into_iter().map(|i| i.to_string()).collect())
 }
 
-fn p_cpu_range(input: &str) -> NomResult<Vec<ResourceIndex>> {
+fn p_cpu_range(input: &str) -> NomResult<'_, Vec<ResourceIndex>> {
     map_res(
         tuple((
             terminated(p_u32, space0),
@@ -262,7 +262,7 @@ fn p_cpu_range(input: &str) -> NomResult<Vec<ResourceIndex>> {
     .parse(input)
 }
 
-fn p_cpu_ranges(input: &str) -> NomResult<Vec<ResourceIndex>> {
+fn p_cpu_ranges(input: &str) -> NomResult<'_, Vec<ResourceIndex>> {
     separated_list1(terminated(tag(","), space0), p_cpu_range)(input)
         .map(|(a, b)| (a, b.into_iter().flatten().collect()))
 }

crates/pyhq/src/client/job.rs

@@ -20,16 +20,16 @@ use pyo3::exceptions::PyException;
 use pyo3::prelude::PyAnyMethods;
 use pyo3::types::PyTuple;
 use pyo3::{Bound, IntoPyObject, PyAny, PyResult, Python};
-use std::collections::{BTreeMap, BTreeSet, HashMap};
+use std::collections::{BTreeSet, HashMap};
 use std::path::{Path, PathBuf};
 use std::time::Duration;
+use tako::JobTaskCount;
 use tako::gateway::{
     CrashLimit, ResourceRequestEntries, ResourceRequestEntry, ResourceRequestVariants,
     TaskDataFlags,
 };
 use tako::program::{FileOnCloseBehavior, ProgramDefinition, StdioDef};
 use tako::resources::{AllocationRequest, NumOfNodes, ResourceAmount};
-use tako::{JobTaskCount, Set};
 
 #[derive(Debug, FromPyObject)]
 enum AllocationValue {

crates/tako/src/internal/common/wrapped.rs

@@ -44,14 +44,14 @@ impl<T: ?Sized> WrappedRcRefCell<T> {
     /// Return a immutable reference to contents. Panics whenever `RefCell::borrow()` would.
     #[inline]
     #[track_caller]
-    pub fn get(&self) -> Ref<T> {
+    pub fn get(&self) -> Ref<'_, T> {
         self.inner.deref().borrow()
     }
 
     /// Return a mutable reference to contents. Panics whenever `RefCell::borrow_mut()` would.
     #[inline]
     #[track_caller]
-    pub fn get_mut(&self) -> RefMut<T> {
+    pub fn get_mut(&self) -> RefMut<'_, T> {
         self.inner.deref().borrow_mut()
     }