fix(windows): NSIS install log integrity and step mirroring

Write %TEMP%\HyperlinksSpaceUpdater.log in three FileWrite calls (timestamp prefix, body, CRLF) instead of one long literal, so NSIS variable parsing does not corrupt lines when paths use $INSTDIR\... alongside $R* and colons in the time stamp.

Use dedicated HspLogHandle / un.HspLogHandle instead of $R9 for the log file, avoiding overlap with nsExec::ExecToLog Pop $R9 in installSection.nsh.

Log junction removal with ${INSTDIR}\current in the mirrored message, matching the recommended ${VAR}\path form.

Introduce HspInstallDetailPrint and use it for each install milestone so DetailPrint lines are also appended to the temp log when the MUI Installing list stays empty.

Made-with: Cursor

Author: anriltine

app/windows/installSection.nsh

@@ -1,6 +1,6 @@
 ; Fork of app-builder-lib/templates/nsis/installSection.nsh (electron-builder).
-; Only change: show installation details (SetDetailsPrint both) instead of none, plus
-; versioned install layout under $INSTDIR\versions\<VERSION> and current junction.
+; Debug: if the Installing list stays empty, open %TEMP%\HyperlinksSpaceUpdater.log — HspInstallDetailPrint
+; mirrors each milestone there (proves NSIS ran the line even when the UI list does not repaint).
 ;
 ; Source lives here (not app/build/). package.json sets directories.buildResources to
 ; "windows" so NSIS resolves this file before templates/nsis/installSection.nsh.
@@ -13,11 +13,8 @@ InitPluginsDir
 
 ; Do not wrap DetailPrint in ${IfNot} ${Silent}: on some builds ${Silent} evaluates in a way that
 ; skips all section DetailPrint lines while the InstFiles SHOW hook still runs (only one line visible).
-; listonly: send DetailPrint into the white list (MUI2 often leaves the list empty with "both" alone).
-SetDetailsPrint listonly
-SetDetailsView show
 ; 7-Zip extraction does not stream filenames into the NSIS list (unlike File commands).
-DetailPrint "Step 1/10 - Preparing ${PRODUCT_NAME} ${VERSION}..."
+!insertmacro HspInstallDetailPrint "Step 1/10 - Preparing ${PRODUCT_NAME} ${VERSION}..."
 
 ; Installed layout: $INSTDIR\versions\<VERSION>\* and $INSTDIR\current → junction to that folder.
 ; For upgrade checks, prefer an existing versioned or legacy flat exe.
@@ -32,7 +29,7 @@ ${EndIf}
 # must be called before uninstallOldVersion
 !insertmacro setLinkVars
 
-DetailPrint "Step 2/10 - Checking that ${PRODUCT_NAME} is not running..."
+!insertmacro HspInstallDetailPrint "Step 2/10 - Checking that ${PRODUCT_NAME} is not running..."
 
 !ifdef ONE_CLICK
   !ifdef HEADER_ICO
@@ -72,7 +69,7 @@ ${if} $isTryToKeepShortcuts == "true"
   ${endIf}
 ${EndIf}
 
-DetailPrint "Step 3/10 - Checking for a previous installation and uninstalling the old build if needed..."
+!insertmacro HspInstallDetailPrint "Step 3/10 - Checking for a previous installation and uninstalling the old build if needed..."
 !insertmacro uninstallOldVersion SHELL_CONTEXT
 !insertmacro handleUninstallResult SHELL_CONTEXT
 
@@ -81,35 +78,32 @@ ${if} $installMode == "all"
   !insertmacro handleUninstallResult HKEY_CURRENT_USER
 ${endIf}
 
-DetailPrint "Step 4/10 - Creating versioned install folder versions\${VERSION}..."
+!insertmacro HspInstallDetailPrint "Step 4/10 - Creating versioned install folder versions\${VERSION}..."
 CreateDirectory "$INSTDIR\versions"
 SetOutPath "$INSTDIR\versions\${VERSION}"
 
 !ifdef UNINSTALLER_ICON
   File /oname=uninstallerIcon.ico "${UNINSTALLER_ICON}"
 !endif
 
-DetailPrint "Step 5/10 - Extracting application package with 7-Zip (longest step; file names are not listed)..."
-; File extraction toggles status_update around compressed reads; keep listbox as the log target.
-SetDetailsPrint listonly
-SetDetailsView show
+!insertmacro HspInstallDetailPrint "Step 5/10 - Extracting application package with 7-Zip (longest step; file names are not listed)..."
 !insertmacro installApplicationFiles
-DetailPrint "Step 6/10 - Extraction finished."
-DetailPrint "Step 7/10 - Pointing 'current' at versions\${VERSION} (directory junction)..."
+!insertmacro HspInstallDetailPrint "Step 6/10 - Extraction finished."
+!insertmacro HspInstallDetailPrint "Step 7/10 - Pointing 'current' at versions\${VERSION} (directory junction)..."
 ; Directory junction so shortcuts and the updater always use …\current\<exe>
 IfFileExists "$INSTDIR\current" hspRemoveOldCurrent hspMklinkCurrent
 hspRemoveOldCurrent:
-  DetailPrint "  (removing existing junction or folder: $INSTDIR\current)"
+  !insertmacro HspInstallDetailPrint "  (removing existing junction or folder: ${INSTDIR}\current)"
   nsExec::ExecToLog '"$SYSDIR\cmd.exe" /c rmdir "$INSTDIR\current"'
   Pop $R9
 hspMklinkCurrent:
-DetailPrint "  (creating junction: current -> versions\${VERSION})"
+!insertmacro HspInstallDetailPrint "  (creating junction: current -> versions\${VERSION})"
 nsExec::ExecToLog '"$SYSDIR\cmd.exe" /c mklink /J "$INSTDIR\current" "$INSTDIR\versions\${VERSION}"'
 Pop $R9
 StrCpy $appExe "$INSTDIR\current\${APP_EXECUTABLE_FILENAME}"
-DetailPrint "Step 8/10 - Writing install location and Add/Remove Programs registry entries..."
+!insertmacro HspInstallDetailPrint "Step 8/10 - Writing install location and Add/Remove Programs registry entries..."
 !insertmacro registryAddInstallInfo
-DetailPrint "Step 9/10 - Creating Start Menu and desktop shortcuts..."
+!insertmacro HspInstallDetailPrint "Step 9/10 - Creating Start Menu and desktop shortcuts..."
 !insertmacro addStartMenuLink $keepShortcuts
 !insertmacro addDesktopLink $keepShortcuts
 
@@ -120,13 +114,12 @@ ${else}
 ${endIf}
 
 !ifmacrodef registerFileAssociations
-  DetailPrint "Registering file associations..."
+  !insertmacro HspInstallDetailPrint "Registering file associations..."
   !insertmacro registerFileAssociations
 !endif
 
 !ifmacrodef customInstall
-  DetailPrint "Step 10/10 - Running final install hooks..."
-  ; So customInstall's DetailPrint targets the listbox.
+  !insertmacro HspInstallDetailPrint "Step 10/10 - Running final install hooks..."
   SetDetailsPrint listonly
   SetDetailsView show
   !insertmacro customInstall

app/windows/installer-hooks.nsi

@@ -48,25 +48,40 @@ Function HspInstFilesShow
 FunctionEnd
 
 Var HspLogFile
+Var HspLogHandle
 Function HspEnsureUpdaterLogPath
   StrCmp $HspLogFile "" hspSetLogPath hspLogPathDone
 hspSetLogPath:
   StrCpy $HspLogFile "$TEMP\HyperlinksSpaceUpdater.log"
 hspLogPathDone:
 FunctionEnd
 
+; Append in three writes: avoids one huge FileWrite string mixing $R0-$R6, colons, and runtime $VAR\path
+; (NSIS recommends ${INSTDIR}\file when a path follows a variable; mixed literals have misparsed before).
 !macro HspAppendUpdaterLog TEXT
   Call HspEnsureUpdaterLogPath
   ${GetTime} "" "L" $R0 $R1 $R2 $R3 $R4 $R5 $R6
   ; FileFunc GetTime (local): $R0=day $R1=month $R2=year $R3=weekday name (unused) $R4:$R5:$R6=time
-  FileOpen $R9 "$HspLogFile" a
-  FileWrite $R9 "[$R2-$R1-$R0 $R4:$R5:$R6] ${TEXT}$\r$\n"
-  FileClose $R9
+  StrCpy $R7 "[$R2-$R1-$R0 $R4:$R5:$R6] "
+  FileOpen $HspLogHandle "$HspLogFile" a
+  FileWrite $HspLogHandle $R7
+  FileWrite $HspLogHandle "${TEXT}"
+  FileWrite $HspLogHandle "$\r$\n"
+  FileClose $HspLogHandle
+!macroend
+
+; Re-assert list mode + mirror to HyperlinksSpaceUpdater.log (debug when MUI listbox stays empty).
+!macro HspInstallDetailPrint MSG
+  SetDetailsPrint listonly
+  SetDetailsView show
+  DetailPrint "${MSG}"
+  !insertmacro HspAppendUpdaterLog "${MSG}"
 !macroend
 !endif
 
 !ifdef BUILD_UNINSTALLER
 Var un.HspLogFile
+Var un.HspLogHandle
 Function un.HspEnsureUpdaterLogPath
   StrCmp $un.HspLogFile "" hspUnSetLogPath hspUnLogPathDone
 hspUnSetLogPath:
@@ -77,9 +92,12 @@ FunctionEnd
 !macro HspAppendUpdaterLog TEXT
   Call un.HspEnsureUpdaterLogPath
   ${GetTime} "" "L" $R0 $R1 $R2 $R3 $R4 $R5 $R6
-  FileOpen $R9 "$un.HspLogFile" a
-  FileWrite $R9 "[$R2-$R1-$R0 $R4:$R5:$R6] ${TEXT}$\r$\n"
-  FileClose $R9
+  StrCpy $R7 "[$R2-$R1-$R0 $R4:$R5:$R6] "
+  FileOpen $un.HspLogHandle "$un.HspLogFile" a
+  FileWrite $un.HspLogHandle $R7
+  FileWrite $un.HspLogHandle "${TEXT}"
+  FileWrite $un.HspLogHandle "$\r$\n"
+  FileClose $un.HspLogHandle
 !macroend
 !endif