Skip to content

Commit 04c558b

Browse files
committed
fix(forge-nsis): remove unused installer launch helper
Remove the now-unreferenced HspShellOpenExeNoActivate function from installer hooks so Forge NSIS builds do not fail on warning 6010 treated as error. Made-with: Cursor
1 parent 8e7f904 commit 04c558b

1 file changed

Lines changed: 0 additions & 18 deletions

File tree

app/windows/installer-hooks.nsi

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -240,24 +240,6 @@ FunctionEnd
240240
StrCpy $isForceCurrentInstall "1"
241241
!macroend
242242

243-
; NSIS 3.0.x ExecShell only accepts SW_SHOW* names, not a numeric nShowCmd — use ShellExecuteW for SW_SHOWNOACTIVATE (4).
244-
; Installer only: uninstaller prebuild defines BUILD_UNINSTALLER and omits HspAppendInstallerMirrorLogVar.
245-
!ifndef BUILD_UNINSTALLER
246-
Function HspShellOpenExeNoActivate
247-
System::Call "shell32::ShellExecuteW(i 0, w \"open\", w \"$INSTDIR\${PRODUCT_FILENAME}.exe\", w \"\", w \"$INSTDIR\", i 4) i.r0"
248-
; Mirror to install log + DetailPrint (replaces old "ExecShell: open …" line in the listbox-only view).
249-
IntCmp $0 32 hspShellExecBad hspShellExecBad hspShellExecOk
250-
hspShellExecBad:
251-
StrCpy $R8 "ShellExecuteW failed (result=$0): $INSTDIR\${PRODUCT_FILENAME}.exe"
252-
Goto hspShellExecDone
253-
hspShellExecOk:
254-
StrCpy $R8 "ShellExecuteW ok (SW_SHOWNOACTIVATE): $INSTDIR\${PRODUCT_FILENAME}.exe"
255-
hspShellExecDone:
256-
DetailPrint "$R8"
257-
Call HspAppendInstallerMirrorLogVar
258-
FunctionEnd
259-
!endif
260-
261243
!macro customInstall
262244
; electron-builder calls this after other install steps; keep listbox output on for final hooks.
263245
; Do not launch app here: we launch from Finish page run option (checked by default) to avoid

0 commit comments

Comments
 (0)