Revert runtime param and just skip upgrade test for bun

Author: kriszyp

integrationTests/security/crl-verification.test.ts

@@ -36,6 +36,7 @@ suite(
 		let crlServer: CrlServerContext | null = null;
 		let certsPath: string; // Track separately for cleanup even if server is stopped
 		if (testsBun) return; // no Bun testing for now
+
 		before(async () => {
 			// 1. Create temp directory for certificates
 			certsPath = await mkdtemp(join(tmpdir(), 'harper-crl-test-'));
@@ -174,6 +175,7 @@ suite(
 suite('CRL Certificate Verification - Disabled', (ctx: ContextWithHarper) => {
 	let certsPath: string;
 	let certs: CrlCertificates;
+	if (testsBun) return; // no Bun testing for now
 
 	before(async () => {
 		certsPath = await mkdtemp(join(tmpdir(), 'harper-crl-disabled-'));
@@ -233,6 +235,7 @@ suite('CRL Certificate Verification - Disabled', (ctx: ContextWithHarper) => {
 suite('CRL Certificate Verification - Fail-Open Mode', (ctx: ContextWithHarper) => {
 	let certsPath: string;
 	let certs: CrlCertificates;
+	if (testsBun) return; // no Bun testing for now
 
 	before(async () => {
 		certsPath = await mkdtemp(join(tmpdir(), 'harper-crl-failopen-'));
@@ -291,6 +294,7 @@ suite('CRL Certificate Verification - Fail-Open Mode', (ctx: ContextWithHarper)
 suite('CRL Certificate Verification - Fail-Closed with Timeout', (ctx: ContextWithHarper) => {
 	let certsPath: string;
 	let certs: CrlCertificates;
+	if (testsBun) return; // no Bun testing for now
 
 	before(async () => {
 		certsPath = await mkdtemp(join(tmpdir(), 'harper-crl-timeout-'));

integrationTests/security/ocsp-verification.test.ts

@@ -167,6 +167,7 @@ suite(
 suite('OCSP Certificate Verification - Disabled', (ctx: ContextWithHarper) => {
 	let certsPath: string;
 	let certs: OcspCertificates;
+	if (testsBun) return; // no Bun testing for now
 
 	before(async () => {
 		certsPath = await mkdtemp(join(tmpdir(), 'harper-ocsp-disabled-'));
@@ -226,6 +227,7 @@ suite('OCSP Certificate Verification - Disabled', (ctx: ContextWithHarper) => {
 suite('OCSP Certificate Verification - Fail-Open Mode', (ctx: ContextWithHarper) => {
 	let certsPath: string;
 	let certs: OcspCertificates;
+	if (testsBun) return; // no Bun testing for now
 
 	before(async () => {
 		certsPath = await mkdtemp(join(tmpdir(), 'harper-ocsp-failopen-'));
@@ -284,6 +286,7 @@ suite('OCSP Certificate Verification - Fail-Open Mode', (ctx: ContextWithHarper)
 suite('OCSP Certificate Verification - Fail-Closed with Timeout', (ctx: ContextWithHarper) => {
 	let certsPath: string;
 	let certs: OcspCertificates;
+	if (testsBun) return; // no Bun testing for now
 
 	before(async () => {
 		certsPath = await mkdtemp(join(tmpdir(), 'harper-ocsp-timeout-'));

integrationTests/upgrade/4.x-upgrade.test.ts

@@ -12,22 +12,20 @@ import {
 } from '../utils/harperLifecycle.ts';
 import { ok } from 'node:assert';
 import { join } from 'node:path';
-import { setTimeout as delay } from 'node:timers/promises';
+const testsBun = process.env.HARPER_RUNTIME === 'bun';
 
 suite('Start 4.x server and test upgrade', (ctx: ContextWithHarper) => {
+	const legacyPath = process.env.HARPER_LEGACY_VERSION_PATH;
+	if (!legacyPath || testsBun) return;
 	before(async () => {
-		const legacyPath = process.env.HARPER_LEGACY_VERSION_PATH;
-		if (!legacyPath) return;
 		await startHarper(ctx, {
 			config: {},
 			env: {
 				TC_AGREEMENT: 'yes',
 				REPLICATION_HOSTNAME: 'localhost',
 			},
 			harperBinPath: join(legacyPath, 'bin', 'harperdb.js'),
-			harperRuntime: 'node', // legacy harperdb.js is node only
 		});
-		console.log('Started legacy harper on node', ctx.harper);
 		await sendOperation(ctx.harper, {
 			operation: 'create_table',
 			table: 'test',
@@ -59,10 +57,7 @@ suite('Start 4.x server and test upgrade', (ctx: ContextWithHarper) => {
 
 	test('upgrade and start', async () => {
 		await killHarper(ctx); // kill old 4.x harper
-		console.log('Killed legacy harper on node', ctx.harper);
-
 		await startHarper(ctx, { config: {}, env: {} }); // start on v5
-		console.log('Starting new harper on node', ctx.harper);
 		let response = await sendOperation(ctx.harper, {
 			operation: 'search_by_conditions',
 			table: 'test',

integrationTests/utils/harperLifecycle.ts

@@ -45,12 +45,6 @@ export interface StartHarperOptions {
 	 * Version of Harper to install and use for this test suite.
 	 */
 	harperBinPath?: string;
-	/**
-	 * Runtime environment for Harper ('node' or 'bun').
-	 * Set via the HARPER_RUNTIME environment variable ('node' or 'bun').
-	 * Defaults to 'node'.
-	 */
-	harperRuntime?: string;
 }
 
 export interface HarperContext {
@@ -120,7 +114,6 @@ interface RunHarperCommandOptions {
 	/** When set, stdout and stderr are written to files in this directory */
 	logDir?: string;
 	harperBinPath?: string; // an explicit location installation of a harper package's bin module
-	harperRuntime?: string;
 }
 
 /**
@@ -137,16 +130,14 @@ function runHarperCommand({
 	completionMessage,
 	logDir,
 	harperBinPath,
-	harperRuntime,
 }: RunHarperCommandOptions): Promise<ChildProcess> {
 	const harperScript = getHarperScript(harperBinPath);
-	harperRuntime ??= HARPER_RUNTIME;
+	const runtime = HARPER_RUNTIME;
 	const runtimeArgs =
-		harperRuntime === 'bun'
+		runtime === 'bun'
 			? [harperScript, ...args]
 			: ['--trace-warnings', '--force-node-api-uncaught-exceptions-policy=true', harperScript, ...args];
-	console.log('running', harperRuntime, runtimeArgs);
-	const proc = spawn(harperRuntime, runtimeArgs, {
+	const proc = spawn(runtime, runtimeArgs, {
 		env: { ...process.env, ...env },
 	});
 
@@ -336,7 +327,6 @@ export async function startHarper(ctx: ContextWithHarper, options?: StartHarperO
 		env: harperEnv,
 		completionMessage: 'successfully started',
 		logDir,
-		harperRuntime: options?.harperRuntime,
 		harperBinPath: options?.harperBinPath,
 	});