Fix system database handling in copyDb and add system database verification test

Author: kriszyp

bin/copyDb.ts

@@ -289,7 +289,7 @@ function openRocksDb(path: string, options: RocksDatabaseOptions & { dupSort?: b
 	}
 	let db;
 	if (options.dupSort) {
-		db = RocksDatabase.open(new RocksIndexStore(path, options));
+		db = new RocksIndexStore(path, options).open();
 	} else {
 		db = RocksDatabase.open(path, options);
 		db.encoder.name = options.name;
@@ -307,8 +307,10 @@ export async function migrateOnStart() {
 	updateConfigValue(CONFIG_PARAMS.STORAGE_MIGRATEONSTART, false);
 
 	try {
-		for (const databaseName in databases) {
-			if (databaseName === 'system') continue;
+		let databaseNames = Object.keys(databases);
+		// system is a dontenum property, so we have to manually add it
+		if (!databaseNames.includes('system')) databaseNames.push('system');
+		for (const databaseName of databaseNames) {
 			if (databaseName.endsWith('-copy')) continue;
 			let rootStore;
 			for (const tableName in databases[databaseName]) {

integrationTests/upgrade/4.x-upgrade.test.ts

@@ -81,7 +81,7 @@ suite('Start 4.x server and test upgrade', (ctx: ContextWithHarper) => {
 				CONFIRM_DOWNGRADE: 'yes',
 			},
 			harperBinPath: join(legacyPath, 'bin', 'harperdb.js'),
-		}); // start on v5
+		}); // start on 4.x again
 		let response = await sendOperation(ctx.harper, {
 			operation: 'search_by_conditions',
 			table: 'test',
@@ -114,6 +114,7 @@ suite('Start 4.x server and test upgrade', (ctx: ContextWithHarper) => {
 			conditions: [{ attribute: 'id', comparator: 'greater_than', value: 'id-4' }],
 		});
 		ok(response.length > 4);
-		existsSync(join(ctx.harper.dataRootDir, 'database', 'system', 'CURRENT')); // marker for rocksdb
+		ok(existsSync(join(ctx.harper.dataRootDir, 'database', 'data', 'CURRENT')));
+		ok(existsSync(join(ctx.harper.dataRootDir, 'database', 'system', 'CURRENT'))); // marker for rocksdb
 	});
 });