fix: Ensure we have a port number when adding the URL

Author: dawsontoth

lib/steps/getEnvVars.js

@@ -95,6 +95,17 @@ export async function getEnvVars(interactive, template, argDeploymentUsername, a
 		if (!target.startsWith('http://') && !target.startsWith('https://')) {
 			target = 'https://' + target;
 		}
+
+		try {
+			const url = new URL(target);
+			if (!url.port) {
+				url.port = '9925';
+			}
+			target = url.toString();
+		} catch {
+			// If it's not a valid URL yet, we'll let it be handled later or it will fail
+		}
+
 		if (!target.endsWith('/')) {
 			target = target + '/';
 		}

lib/steps/getEnvVars.test.js

@@ -43,7 +43,7 @@ describe('getEnvVars', () => {
 		expect(result).toEqual({
 			envVars: {
 				username: 'testuser',
-				target: 'https://testtarget/',
+				target: 'https://testtarget:9925/',
 				password: 'YOUR_CLUSTER_PASSWORD',
 			},
 			cancelled: false,
@@ -77,7 +77,7 @@ describe('getEnvVars', () => {
 		expect(result).toEqual({
 			envVars: {
 				username: 'promptuser',
-				target: 'https://prompttarget/',
+				target: 'https://prompttarget:9925/',
 				password: 'promptpassword',
 			},
 			cancelled: false,
@@ -147,7 +147,7 @@ describe('getEnvVars', () => {
 
 		const result = await getEnvVars(false, 'vanilla', argUsername, argTarget);
 
-		expect(result.envVars.target).toBe('https://example.com/');
+		expect(result.envVars.target).toBe('https://example.com:9925/');
 		process.env._HARPER_TEST_CLI = originalEnv;
 	});
 
@@ -159,7 +159,7 @@ describe('getEnvVars', () => {
 
 		const result = await getEnvVars(false, 'vanilla', argUsername, argTarget);
 
-		expect(result.envVars.target).toBe('http://example.com/');
+		expect(result.envVars.target).toBe('http://example.com:9925/');
 		process.env._HARPER_TEST_CLI = originalEnv;
 	});
 
@@ -171,7 +171,7 @@ describe('getEnvVars', () => {
 
 		const result = await getEnvVars(false, 'vanilla', argUsername, argTarget);
 
-		expect(result.envVars.target).toBe('https://example.com/');
+		expect(result.envVars.target).toBe('https://example.com:9925/');
 		process.env._HARPER_TEST_CLI = originalEnv;
 	});