enable warnings as errors, optimizations

fix warnings

Author: korli

Makefile

@@ -122,7 +122,7 @@ LOCAL_INCLUDE_PATHS =
 
 #	specify the level of optimization that you desire
 #	NONE, SOME, FULL
-OPTIMIZE=
+OPTIMIZE= FULL
 
 # 	specify here the codes for languages you are going
 # 	to support in this application. The default "en"
@@ -143,7 +143,7 @@ DEFINES=
 #	if unspecified default warnings will be used
 #	NONE = supress all warnings
 #	ALL = enable all warnings
-WARNINGS =
+WARNINGS = ALL
 
 #	specify whether image symbols will be created
 #	so that stack crawls in the debugger are meaningful
@@ -156,7 +156,7 @@ SYMBOLS =
 DEBUGGER =
 
 #	specify additional compiler flags for all files
-COMPILER_FLAGS =
+COMPILER_FLAGS = -Werror
 
 #	specify additional linker flags
 LINKER_FLAGS =

addons/AddOns/AdaptiveHistogramEqualization/Makefile

@@ -92,7 +92,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}
 
 #	Specify the level of optimization that you want. Specify either NONE (O0),
 #	SOME (O1), FULL (O2), or leave blank (for the default optimization level).
-OPTIMIZE := 
+OPTIMIZE := FULL
 
 # 	Specify the codes for languages you are going to support in this
 # 	application. The default "en" one must be provided too. "make catkeys"
@@ -110,7 +110,7 @@ DEFINES =
 
 #	Specify the warning level. Either NONE (suppress all warnings),
 #	ALL (enable all warnings), or leave blank (enable default warnings).
-WARNINGS = 
+WARNINGS = ALL
 
 #	With image symbols, stack crawls in the debugger are meaningful.
 #	If set to "TRUE", symbols will be created.
@@ -121,7 +121,7 @@ SYMBOLS :=
 DEBUGGER := 
 
 #	Specify any additional compiler flags to be used.
-COMPILER_FLAGS = 
+COMPILER_FLAGS = -Werror
 
 #	Specify any additional linker flags to be used.
 LINKER_FLAGS = 

addons/AddOns/AntiDitherer/AntiDitherer.cpp

@@ -155,9 +155,6 @@ AntiDithererManipulator::anti_dither()
 	if (selection != NULL && selection->IsEmpty() == false)
 		bounds = selection->GetBoundingRect();
 
-	int32 width = bounds.IntegerWidth();
-	int32 height = bounds.IntegerHeight();
-
 	float bounds_left = bounds.left;
 	float bounds_right = bounds.right;
 	float bounds_top = bounds.top;

addons/AddOns/AntiDitherer/Makefile

@@ -92,7 +92,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}
 
 #	Specify the level of optimization that you want. Specify either NONE (O0),
 #	SOME (O1), FULL (O2), or leave blank (for the default optimization level).
-OPTIMIZE := 
+OPTIMIZE := FULL
 
 # 	Specify the codes for languages you are going to support in this
 # 	application. The default "en" one must be provided too. "make catkeys"
@@ -110,7 +110,7 @@ DEFINES =
 
 #	Specify the warning level. Either NONE (suppress all warnings),
 #	ALL (enable all warnings), or leave blank (enable default warnings).
-WARNINGS = 
+WARNINGS = ALL
 
 #	With image symbols, stack crawls in the debugger are meaningful.
 #	If set to "TRUE", symbols will be created.
@@ -121,7 +121,7 @@ SYMBOLS :=
 DEBUGGER := 
 
 #	Specify any additional compiler flags to be used.
-COMPILER_FLAGS = 
+COMPILER_FLAGS = -Werror
 
 #	Specify any additional linker flags to be used.
 LINKER_FLAGS = 

addons/AddOns/Blur/Blur.cpp

@@ -94,10 +94,6 @@ BlurManipulator::ManipulateBitmap(
 		return NULL;
 	}
 
-	BBitmap* source_bitmap;
-	BBitmap* target_bitmap;
-	BBitmap* new_bitmap = NULL;
-
 	return original;
 }
 

addons/AddOns/Blur/Makefile

@@ -92,7 +92,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}
 
 #	Specify the level of optimization that you want. Specify either NONE (O0),
 #	SOME (O1), FULL (O2), or leave blank (for the default optimization level).
-OPTIMIZE := 
+OPTIMIZE := FULL
 
 # 	Specify the codes for languages you are going to support in this
 # 	application. The default "en" one must be provided too. "make catkeys"
@@ -110,7 +110,7 @@ DEFINES =
 
 #	Specify the warning level. Either NONE (suppress all warnings),
 #	ALL (enable all warnings), or leave blank (enable default warnings).
-WARNINGS = 
+WARNINGS = ALL
 
 #	With image symbols, stack crawls in the debugger are meaningful.
 #	If set to "TRUE", symbols will be created.
@@ -121,7 +121,7 @@ SYMBOLS :=
 DEBUGGER := 
 
 #	Specify any additional compiler flags to be used.
-COMPILER_FLAGS = 
+COMPILER_FLAGS = -Werror
 
 #	Specify any additional linker flags to be used.
 LINKER_FLAGS = 

addons/AddOns/Brightness/Brightness.cpp

@@ -212,7 +212,6 @@ BrightnessManipulator::thread_function(int32 thread_number)
 		float missed_update = 0;
 
 		// Loop through all pixels in original.
-		uint32 sum;
 		brightness *= 3;
 		uint8 brighness_array[256];
 		for (int32 i = 0; i < 256; i++)

addons/AddOns/Brightness/Makefile

@@ -92,7 +92,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}
 
 #	Specify the level of optimization that you want. Specify either NONE (O0),
 #	SOME (O1), FULL (O2), or leave blank (for the default optimization level).
-OPTIMIZE := 
+OPTIMIZE := FULL
 
 # 	Specify the codes for languages you are going to support in this
 # 	application. The default "en" one must be provided too. "make catkeys"
@@ -110,7 +110,7 @@ DEFINES =
 
 #	Specify the warning level. Either NONE (suppress all warnings),
 #	ALL (enable all warnings), or leave blank (enable default warnings).
-WARNINGS = 
+WARNINGS = ALL
 
 #	With image symbols, stack crawls in the debugger are meaningful.
 #	If set to "TRUE", symbols will be created.
@@ -121,7 +121,7 @@ SYMBOLS :=
 DEBUGGER := 
 
 #	Specify any additional compiler flags to be used.
-COMPILER_FLAGS = 
+COMPILER_FLAGS = -Werror
 
 #	Specify any additional linker flags to be used.
 LINKER_FLAGS = 

addons/AddOns/ColorBalance/Makefile

@@ -92,7 +92,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}
 
 #	Specify the level of optimization that you want. Specify either NONE (O0),
 #	SOME (O1), FULL (O2), or leave blank (for the default optimization level).
-OPTIMIZE := 
+OPTIMIZE := FULL
 
 # 	Specify the codes for languages you are going to support in this
 # 	application. The default "en" one must be provided too. "make catkeys"
@@ -110,7 +110,7 @@ DEFINES =
 
 #	Specify the warning level. Either NONE (suppress all warnings),
 #	ALL (enable all warnings), or leave blank (enable default warnings).
-WARNINGS = 
+WARNINGS = ALL
 
 #	With image symbols, stack crawls in the debugger are meaningful.
 #	If set to "TRUE", symbols will be created.
@@ -121,7 +121,7 @@ SYMBOLS :=
 DEBUGGER := 
 
 #	Specify any additional compiler flags to be used.
-COMPILER_FLAGS = 
+COMPILER_FLAGS = -Werror
 
 #	Specify any additional linker flags to be used.
 LINKER_FLAGS = 

addons/AddOns/ColorReducer/Makefile

@@ -94,7 +94,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}
 
 #	Specify the level of optimization that you want. Specify either NONE (O0),
 #	SOME (O1), FULL (O2), or leave blank (for the default optimization level).
-OPTIMIZE := 
+OPTIMIZE := FULL
 
 # 	Specify the codes for languages you are going to support in this
 # 	application. The default "en" one must be provided too. "make catkeys"
@@ -112,7 +112,7 @@ DEFINES =
 
 #	Specify the warning level. Either NONE (suppress all warnings),
 #	ALL (enable all warnings), or leave blank (enable default warnings).
-WARNINGS = 
+WARNINGS = ALL
 
 #	With image symbols, stack crawls in the debugger are meaningful.
 #	If set to "TRUE", symbols will be created.
@@ -123,7 +123,7 @@ SYMBOLS :=
 DEBUGGER := 
 
 #	Specify any additional compiler flags to be used.
-COMPILER_FLAGS = 
+COMPILER_FLAGS = -Werror
 
 #	Specify any additional linker flags to be used.
 LINKER_FLAGS =