deployment lifecycle: deploy, halt on error

Author: jfranzoi-gucci

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 Versions before 2.0 were only available on internal repository, before open-sourcing the project.
 
+## 2.7
+
+* deployment lifecycle: deploy, halt on error
+
 ## 2.6
 
 * helpers: aws_cf_distribution

test/fake/lib/ecs-deploy

@@ -2,4 +2,8 @@
 
 source "${BASH_SOURCE%/*}/../common"
 
-fake_log_in "$( basename "$0" ) $@"
+fake_log_in "$( basename "$0" ) $@"
+[[ ! -z "$YOKE_FAKES_ECSDEPLOY_EXIT" ]] && exit $YOKE_FAKES_ECSDEPLOY_EXIT
+
+# success
+exit 0

test/unit/deployment.bats

@@ -164,7 +164,7 @@ last_execution_output() {
     assert_equal "$family" "Hello"
 }
 
-@test 'lifecycle - post-deploy' {
+@test 'lifecycle - post-deploy executed on success' {
     run ./yoke install -c any -s any -t 12345 -w test/deployments/lifecycle_post_deploy
     assert_equal $status 0 || fail "${lines[@]}"
 
@@ -173,6 +173,15 @@ last_execution_output() {
     [[ $output =~ $expected ]] || fail "not matching. expected: \"$expected\", actual: \"$output\""
 }
 
+@test 'lifecycle - post-deploy skipped on failure' {
+    YOKE_FAKES_ECSDEPLOY_EXIT=55 run ./yoke install -c any -s any -t 12345 -w test/deployments/lifecycle_post_deploy
+    assert_equal $status 55 || fail "${lines[@]}"
+
+    local unexpected='On post-deploy'
+    local output=$( last_execution_output )
+    [[ ! $output =~ $unexpected ]] || fail "unexpected: \"$unexpected\", actual: \"$output\""
+}
+
 @test 'lifecycle - post-deploy, with ECS environment variables' {
     run ./yoke install -c my-cluster -s my-service -t 12345 -w test/deployments/lifecycle_post_deploy
     assert_equal $status 0 || fail "${lines[@]}"

yoke

@@ -182,6 +182,11 @@ function do_deploy() {
 
     [[ "$DEBUG" != "false" ]] && log "[deploy] executing (${#command_line[@]} params): ecs-deploy ${command_line[@]}"
     ecs-deploy ${command_line[@]}
+
+    local ecs_deploy_result=$?
+    [[ $ecs_deploy_result -eq 0 ]] || {
+        echo "Could not deploy"; exit $ecs_deploy_result;
+    }
 }
 
 # skip when sourcing the script
@@ -253,6 +258,5 @@ if [ "$0" = "$BASH_SOURCE" ] ; then
 
     do_initialize
     do_deploy
-    
     on_post_deploy
 fi