Skip to content

Commit 4bb12ae

Browse files
dry-run, delegated to ecs-deploy; container images, more info
1 parent 3be2021 commit 4bb12ae

4 files changed

Lines changed: 12 additions & 5 deletions

File tree

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
Versions before 2.0 were only available on internal repository, before open-sourcing the project.
44

5+
## 2.5
6+
7+
* updated dependencies: ecs-deploy to 3.10.6 (fork)
8+
* rollback, mode info: current task definition containers' image, more info
9+
* dry-run mode, delegating to ecs-deploy
10+
511
## 2.4
612

713
* updated dependencies: ecs-deploy to 3.10.5 (fork)

bin/install

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ mkdir -p "$BIN_DIR" > /dev/null 2>&1
117117

118118
[[ $SCOPE == "--all" || $SCOPE == "--app" ]] && {
119119
# application tools
120-
install_github_tag GuccioGucci/ecs-deploy 3.10.5
120+
install_github_tag GuccioGucci/ecs-deploy 3.10.6
121121
install_github_release noqcks/gucci 1.5.2
122122
}
123123

test/unit/deployment.bats

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,9 @@ last_execution_output() {
150150
run ./yoke update -c any -s any -t any --dry-run
151151
assert_equal $status 0 || fail "${lines[@]}"
152152

153-
[[ ! -r "$YOKE_FAKES_LOGGING" ]] || fail "not expected to exist $YOKE_FAKES_LOGGING. content: \"$( cat $YOKE_FAKES_LOGGING )\""
153+
local expected='--dry-run'
154+
local commands="$( cat $YOKE_FAKES_LOGGING )"
155+
[[ $commands =~ $expected ]] || fail "not matching. expected: \"$expected\", actual: \"$commands\""
154156
}
155157

156158
@test 'shell running in working directory' {

yoke

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,11 +188,10 @@ function do_deploy() {
188188
[[ "$COMMAND" == "update" ]] && command_line=("-c" "$CLUSTER" "-n" "$SERVICE" "--tag-only" "$IMAGE_TAG" "-i" "ignored-image" $( flags_confirmation ) "--timeout" "$TIMEOUT")
189189
[[ "$COMMAND" == "install" ]] && command_line=("-c" "$CLUSTER" "-n" "$SERVICE" "--tag-only" "$IMAGE_TAG" "-i" "ignored-image" $( flags_install ) $( flags_confirmation ) "--timeout" "$TIMEOUT")
190190
[[ ! -z "$PRUNE_TASK_DEFINITIONS" ]] && command_line+=("--max-definitions" "$PRUNE_TASK_DEFINITIONS")
191-
191+
[[ "$DRY_RUN" != "false" ]] && command_line+=("--dry-run")
192192
[[ "$DEBUG" != "false" ]] && command_line+=("--verbose")
193-
[[ "$DEBUG" != "false" ]] && log "[deploy] executing (${#command_line[@]} params): ecs-deploy ${command_line[@]}"
194193

195-
[[ "$DRY_RUN" != "false" ]] && exit 0
194+
[[ "$DEBUG" != "false" ]] && log "[deploy] executing (${#command_line[@]} params): ecs-deploy ${command_line[@]}"
196195
ecs-deploy ${command_line[@]}
197196
}
198197

0 commit comments

Comments
 (0)