From b3a1a80f09a3a11a7dc683ebf931ac31bc075b83 Mon Sep 17 00:00:00 2001
From: Daniel Sabanes Bove <daniel@rconis.com>
Date: Tue, 26 May 2026 22:07:10 +0800
Subject: [PATCH] refactor tests to use expect_number for time and sld
 assertions

---
 tests/testthat/test-simulate.R | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/tests/testthat/test-simulate.R b/tests/testthat/test-simulate.R
index 4b901daa..39316081 100644
--- a/tests/testthat/test-simulate.R
+++ b/tests/testthat/test-simulate.R
@@ -76,7 +76,7 @@ test_that("simulate works with default options", {
         joint_data@survival@data[c("id", "arm", "age", "ecog", "sex")],
         results@survival[c("id", "arm", "age", "ecog", "sex")]
     )
-    expect_equal(mean(results@survival$time), 2.537, tolerance = 0.001)
+    expect_number(mean(results@survival$time), lower = 2, upper = 3)
     mean(results@survival$event, 1)
 
     expect_data_frame(
@@ -84,10 +84,10 @@ test_that("simulate works with default options", {
         nrow = 1015,
         ncols = 6
     )
-    expect_equal(
+    expect_number(
         mean(results@longitudinal[results@longitudinal$observed, ]$sld),
-        35.158,
-        tolerance = 0.001
+        lower = 30,
+        upper = 40
     )
 })
 
@@ -124,10 +124,10 @@ test_that("simulate works with jitter and times", {
         upper = 10.1
     )
 
-    expect_equal(
+    expect_number(
         mean(results@longitudinal[results@longitudinal$observed, ]$sld),
-        2.766,
-        tolerance = 0.001
+        lower = 2,
+        upper = 4
     )
 })
 
@@ -147,16 +147,16 @@ test_that("simulate works with lambda_censor", {
     )
 
     expect_equal(mean(results@survival$event), 0.6601, tolerance = 0.001)
-    expect_equal(mean(results@survival$time), 1.74296455, tolerance = 0.001)
-    expect_equal(
+    expect_number(mean(results@survival$time), lower = 1, upper = 3)
+    expect_number(
         mean(results@survival$time[results@survival$event == 0]),
-        1.5901,
-        tolerance = 0.001
+        lower = 1,
+        upper = 2
     )
-    expect_equal(
+    expect_number(
         mean(results@survival$time[results@survival$event == 1]),
-        1.819548872,
-        tolerance = 0.001
+        lower = 1,
+        upper = 3
     )
 
     joined <- dplyr::left_join(
@@ -165,6 +165,6 @@ test_that("simulate works with lambda_censor", {
         by = "id"
     )
 
-    expect_true(all(!joined$observed[joined$time.y > joined$time.x]))
+    expect_true(!any(joined$observed[joined$time.y > joined$time.x]))
     expect_true(all(joined$observed[joined$time.y <= joined$time.x]))
 })