Commit 572375a
committed
Reviewer Feedback Incorporated #1
Centralise staggered-death handling in TScholaEnvironment::Step
Snapshot previously-dead agents before delegating to the Blueprint
Step(), forward only live-agent actions, and restore the full
pre-step snapshot afterwards. Replaces the per-field flag patch
and the Python-side no-op padding with a single wrapper-level
guard that covers every reset protocol (Disabled, SameStep,
NextStep) without duplication in AbstractGymConnector.
Restoring the full FAgentState (rather than cherry-picking
bTerminated/bTruncated/Reward) prevents stale observations or
future FAgentState members from leaking out of the Blueprint
boundary for agents that are already terminal.1 parent f7e9e57 commit 572375a
File tree
2 files changed
+403
-2
lines changed- Source/ScholaTraining/Public/Environment
- Test/rllib
2 files changed
+403
-2
lines changedLines changed: 42 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
123 | 132 | | |
124 | 133 | | |
125 | 134 | | |
126 | 135 | | |
127 | | - | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
128 | 168 | | |
129 | 169 | | |
130 | 170 | | |
| |||
0 commit comments