From c462b40f4d46355fb2e8a1a29cbae33cf1f9eeb5 Mon Sep 17 00:00:00 2001 From: Johannes Visintini Date: Thu, 7 May 2026 20:13:58 +0200 Subject: [PATCH 1/3] =?UTF-8?q?fix:=20cycleway=20topic=20didn't=20ignore?= =?UTF-8?q?=20features=20that=20set=20value=20=E2=80=9Cno=E2=80=9D?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- ohsome_quality_api/topics/presets.yaml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/ohsome_quality_api/topics/presets.yaml b/ohsome_quality_api/topics/presets.yaml index f73de2103..08f88f969 100644 --- a/ohsome_quality_api/topics/presets.yaml +++ b/ohsome_quality_api/topics/presets.yaml @@ -171,14 +171,14 @@ cycleway: aggregation_type: length filter: >- ((cycleway=* and cycleway!=no) - or (cycleway:both=*) - or (cycleway:right=*) - or (cycleway:left=*) - or (cycleway:right:lane=*) - or (cycleway:both:lane=*) - or (cycleway:left:lane=*) - or (cycleway:left:oneway=*) - or (cycleway:right:oneway=*) + or ((cycleway:both=*) and (cycleway:both!=no)) + or ((cycleway:right=*) and (cycleway:right!=no)) + or ((cycleway:left=*) and (cycleway:left!=no)) + or ((cycleway:right:lane=*) and (cycleway:right:lane!=no)) + or ((cycleway:both:lane=*) and (cycleway:both:lane!=no)) + or ((cycleway:left:lane=*) and (cycleway:left:lane!=no)) + or ((cycleway:left:oneway=*) and (cycleway:left:oneway!=no)) + or ((cycleway:right:oneway=*) and (cycleway:right:oneway!=no)) or (highway=cycleway) or (highway=path and bicycle=designated) or (bicycle_road=yes) From 16dee76c7d097f9abbea89c860107b764d7c5759 Mon Sep 17 00:00:00 2001 From: Johannes Visintini Date: Thu, 7 May 2026 20:25:12 +0200 Subject: [PATCH 2/3] chore: update CHANGELOG --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1998f0827..859a7116a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,8 +10,10 @@ - build: upgrade pytest-approval and recreate approval files (4bdf27b5) - Upgrade of pytest-approval included breaking changes to the approval file naming scheme. All approval files are recreate (--auto-approve). +- fix: topic cycleway did include ways with cycleway features with value “no” ([1018]) -[#1017] https://github.com/GIScience/ohsome-quality-api/pull/1017 +[#1017]: https://github.com/GIScience/ohsome-quality-api/pull/1017 +[#1018]: https://github.com/GIScience/ohsome-quality-api/pull/1018 ## Release 1.17.1 From 1218fd3e1fe5a40bc43e3f88d99c1fb0c6bd3c15 Mon Sep 17 00:00:00 2001 From: Johannes Visintini Date: Fri, 8 May 2026 11:35:52 +0200 Subject: [PATCH 3/3] Update ohsome_quality_api/topics/presets.yaml Co-authored-by: Martin Raifer --- ohsome_quality_api/topics/presets.yaml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/ohsome_quality_api/topics/presets.yaml b/ohsome_quality_api/topics/presets.yaml index 08f88f969..279d624f7 100644 --- a/ohsome_quality_api/topics/presets.yaml +++ b/ohsome_quality_api/topics/presets.yaml @@ -171,14 +171,14 @@ cycleway: aggregation_type: length filter: >- ((cycleway=* and cycleway!=no) - or ((cycleway:both=*) and (cycleway:both!=no)) - or ((cycleway:right=*) and (cycleway:right!=no)) - or ((cycleway:left=*) and (cycleway:left!=no)) - or ((cycleway:right:lane=*) and (cycleway:right:lane!=no)) - or ((cycleway:both:lane=*) and (cycleway:both:lane!=no)) - or ((cycleway:left:lane=*) and (cycleway:left:lane!=no)) - or ((cycleway:left:oneway=*) and (cycleway:left:oneway!=no)) - or ((cycleway:right:oneway=*) and (cycleway:right:oneway!=no)) + or (cycleway:both=* and cycleway:both!=no) + or (cycleway:right=* and cycleway:right!=no) + or (cycleway:left=* and cycleway:left!=no) + or (cycleway:right:lane=* and cycleway:right:lane!=no) + or (cycleway:both:lane=* and cycleway:both:lane!=no) + or (cycleway:left:lane=* and cycleway:left:lane!=no) + or (cycleway:left:oneway=* and cycleway:left:oneway!=no) + or (cycleway:right:oneway=* and cycleway:right:oneway!=no) or (highway=cycleway) or (highway=path and bicycle=designated) or (bicycle_road=yes)