Godot addon: Don't call chmod on Unix systems, use Godot built-in,

capture stderr

Attempted fix for #286

Author: NathanLovato

addons/GDQuest_GDScript_formatter/install_and_update.gd

@@ -8,7 +8,6 @@ enum HttpRequestState {
 }
 
 const URL_GITHUB_API_LATEST_RELEASE = "https://api.github.com/repos/gdquest/GDScript-formatter/releases/latest"
-
 signal installation_completed(binary_path: String)
 signal installation_failed(error_message: String)
 
@@ -228,6 +227,20 @@ func _download_and_install_binary(zip_data: PackedByteArray, platform_info: Dict
 	file.close()
 
 	if not OS.get_name().to_lower().contains("windows"):
-		OS.execute("chmod", ["+x", binary_path])
+		# This should be equivalent to setting the binary to permissions 755
+		const UNIX_EXECUTABLE_PERMISSIONS = (
+			FileAccess.UNIX_READ_OWNER
+			| FileAccess.UNIX_WRITE_OWNER
+			| FileAccess.UNIX_EXECUTE_OWNER
+			| FileAccess.UNIX_READ_GROUP
+			| FileAccess.UNIX_EXECUTE_GROUP
+			| FileAccess.UNIX_READ_OTHER
+			| FileAccess.UNIX_EXECUTE_OTHER
+		)
+		var permissions_error := FileAccess.set_unix_permissions(binary_path, UNIX_EXECUTABLE_PERMISSIONS)
+		if permissions_error != OK:
+			push_error("Failed to make formatter executable: ", binary_path)
+			DirAccess.remove_absolute(binary_path)
+			return ""
 
 	return binary_path

addons/GDQuest_GDScript_formatter/plugin.gd

@@ -90,7 +90,10 @@ func _enter_tree() -> void:
 	installer.installation_completed.connect(
 		func _on_installation_completed(binary_path: String) -> void:
 			set_editor_setting(SETTING_FORMATTER_PATH, binary_path)
-			_has_formatter_command = true
+			_has_formatter_command = has_command(binary_path)
+			if not _has_formatter_command:
+				push_error("GDScript Formatter: Installed binary cannot be executed: " + binary_path)
+				return
 			add_format_command()
 			add_lint_command()
 			# After installing the formatter we can add the menu option to show the uninstall command
@@ -367,7 +370,7 @@ func has_command(command: String) -> bool:
 	if command.is_empty():
 		return false
 	var output: Array = []
-	var exit_code := OS.execute(command, ["--version"], output)
+	var exit_code := OS.execute(command, ["--version"], output, true)
 	return exit_code == OK
 
 
@@ -629,6 +632,7 @@ func format_code(script: GDScript, force_reorder := false, source_content: Varia
 		get_editor_setting(SETTING_FORMATTER_PATH),
 		formatter_arguments,
 		output,
+		true,
 	)
 
 	var formatted_content := ""