Some Bugs when building on Windows (uri_facade_win.cpp,socket_channel.cpp AND tcp_server.cpp)

[HILMR]

1. Up to now, the master branch still does not merge the modifications described in issue Definition doesn't match declaration in uri_facade_win.cpp/uri_facade.h #311 and Bug fixes for Windows and the OPC UA server #312
2. There are still errors caused by the different socket interface between Windows and Linux

• freeopcua/src/core/socket_channel.cpp

  Lines 51 to 54 in bd13aee

  	void OpcUa::SocketChannel::Stop()
  	{
  	close(Socket);
  	}

  void OpcUa::SocketChannel::Stop()
  {
    closesocket(Socket); //API For Windows
    //close(Socket); //API For Linux
  }

• freeopcua/src/server/tcp_server.cpp

  Lines 11 to 13 in bd13aee

  	#ifdef _WIN32
  	#include <windows.h>
  	#endif

  #ifdef _WIN32
  #include <WinSock2.h> // "SD_BOTH" declared in this header file
  #include <windows.h>
  #endif

• freeopcua/src/server/tcp_server.cpp

  Lines 175 to 185 in bd13aee

  	virtual void Stop()
  	{
  	if (ServerThread)
  	{
  	LOG_INFO(Logger, "shutting down opc ua binary server");
  	Stopped = true;
  	shutdown(Socket, SHUT_RDWR);
  	ServerThread->Join();
  	ServerThread.reset();
  	}
  	}

    virtual void Stop()
    {
      if (ServerThread)
        {
          LOG_INFO(Logger, "shutting down opc ua binary server");
          Stopped = true;
          shutdown(Socket, SD_BOTH); //API For Windows
          //shutdown(Socket, SHUT_RDWR); //API For Linux
          ServerThread->Join();
          ServerThread.reset();
        }
    }

Previously, the python version of this project is very easy to use, but due to some requirements changes, I have to develop the C + + version on windows. However, it is found that the support of this project for windows is not so friendly. I hope the author can further optimize it. Thank you :)

[AVerutin]

1. Up to now, the master branch still does not merge the modifications described in issue Definition doesn't match declaration in uri_facade_win.cpp/uri_facade.h #311 and Bug fixes for Windows and the OPC UA server #312
2. There are still errors caused by the different socket interface between Windows and Linux

• freeopcua/src/core/socket_channel.cpp

  Lines 51 to 54 in bd13aee

  	void OpcUa::SocketChannel::Stop()
  	{
  	close(Socket);
  	}

  void OpcUa::SocketChannel::Stop()
  {
    closesocket(Socket); //API For Windows
    //close(Socket); //API For Linux
  }

• freeopcua/src/server/tcp_server.cpp

  Lines 11 to 13 in bd13aee

  	#ifdef _WIN32
  	#include <windows.h>
  	#endif

  #ifdef _WIN32
  #include <WinSock2.h> // "SD_BOTH" declared in this header file
  #include <windows.h>
  #endif

• freeopcua/src/server/tcp_server.cpp

  Lines 175 to 185 in bd13aee

  	virtual void Stop()
  	{
  	if (ServerThread)
  	{
  	LOG_INFO(Logger, "shutting down opc ua binary server");
  	Stopped = true;
  	shutdown(Socket, SHUT_RDWR);
  	ServerThread->Join();
  	ServerThread.reset();
  	}
  	}

    virtual void Stop()
    {
      if (ServerThread)
        {
          LOG_INFO(Logger, "shutting down opc ua binary server");
          Stopped = true;
          shutdown(Socket, SD_BOTH); //API For Windows
          //shutdown(Socket, SHUT_RDWR); //API For Linux
          ServerThread->Join();
          ServerThread.reset();
        }
    }

Previously, the python version of this project is very easy to use, but due to some requirements changes, I have to develop the C + + version on windows. However, it is found that the support of this project for windows is not so friendly. I hope the author can further optimize it. Thank you :)

Hi. Did you find anything instead this library?

[guojing555]

    您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

[AVerutin]

Thank you