Skip to content

Modifying transient_heat_equation.jl#1304

Closed
Avina-cK wants to merge 5 commits intoFerrite-FEM:masterfrom
Avina-cK:patch-2
Closed

Modifying transient_heat_equation.jl#1304
Avina-cK wants to merge 5 commits intoFerrite-FEM:masterfrom
Avina-cK:patch-2

Conversation

@Avina-cK
Copy link
Copy Markdown
Contributor

  • Added reference to fe_intro for derivation and discretisation.
  • Changed notation of trial functions to be consistent with previous tutorials (v -> δu).
  • Modified doassembly functions into one function for K, M and f. (If there is a reason why they were in two different function, please let me know since I am new to this library).

Added reference to fe_intro for derivation and discretisation.
Changed notation of trial functions to be consistent with previous tutorials (v -> δu). 
Modified doassembly functions into one function for K, M and f. (If there is a reason why they were in two different function, please let me know since I am new to this library).
@Avina-cK Avina-cK marked this pull request as draft March 12, 2026 16:14
Copy link
Copy Markdown
Contributor Author

@Avina-cK Avina-cK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor formatting corrections.

@Avina-cK Avina-cK marked this pull request as ready for review March 12, 2026 16:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.25%. Comparing base (2ecfdd4) to head (745a28d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1304   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          40       40           
  Lines        6757     6757           
=======================================
  Hits         6369     6369           
  Misses        388      388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Avina-cK Avina-cK marked this pull request as draft March 13, 2026 12:30
possibly corrected 'end' error.
@termi-official
Copy link
Copy Markdown
Member

You have some trailing white spaces (https://github.com/Ferrite-FEM/Ferrite.jl/actions/runs/23051101170/job/66952242317?pr=1304). These can be automatically removed by running runic. Will try to give you a detailed review later today.

@fredrikekre
Copy link
Copy Markdown
Member

IIRC there is an argument for not using δu for the transient problem since the test functions isn't really a variation of u, but I don't recall the details.

@Avina-cK
Copy link
Copy Markdown
Contributor Author

IIRC there is an argument for not using δu for the transient problem since the test functions isn't really a variation of u, but I don't recall the details.

That makes sense. Perhaps we could switch to another symbol for test functions. I propose φ. The use of v can be a bit confusing because it's used as a second variable, after u.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants