Modifying transient_heat_equation.jl#1304
Modifying transient_heat_equation.jl#1304Avina-cK wants to merge 5 commits intoFerrite-FEM:masterfrom
Conversation
Avina-cK
commented
Mar 12, 2026
- Added reference to fe_intro for derivation and discretisation.
- Changed notation of trial functions to be consistent with previous tutorials (v -> δu).
- Modified doassembly functions into one function for K, M and f. (If there is a reason why they were in two different function, please let me know since I am new to this library).
Added reference to fe_intro for derivation and discretisation. Changed notation of trial functions to be consistent with previous tutorials (v -> δu). Modified doassembly functions into one function for K, M and f. (If there is a reason why they were in two different function, please let me know since I am new to this library).
Avina-cK
left a comment
There was a problem hiding this comment.
minor formatting corrections.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1304 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 40 40
Lines 6757 6757
=======================================
Hits 6369 6369
Misses 388 388 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
possibly corrected 'end' error.
|
You have some trailing white spaces (https://github.com/Ferrite-FEM/Ferrite.jl/actions/runs/23051101170/job/66952242317?pr=1304). These can be automatically removed by running runic. Will try to give you a detailed review later today. |
|
IIRC there is an argument for not using δu for the transient problem since the test functions isn't really a variation of u, but I don't recall the details. |
That makes sense. Perhaps we could switch to another symbol for test functions. I propose φ. The use of v can be a bit confusing because it's used as a second variable, after u. |
Removed trailing whitespaces.