Minor corrections in heat_equation.jl#1298
Merged
KnutAM merged 1 commit intoFerrite-FEM:masterfrom Mar 9, 2026
Merged
Conversation
- generate_grid() creates a square [-1,1]x[-1,1] and not a unit square (which is [0,1]x[0,1]). - tiny spelling mistake in the comments on a code snippet.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1298 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 40 40
Lines 6757 6757
=======================================
Hits 6369 6369
Misses 388 388 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thank you @Avina-cK! Looks good! You marked this as draft - if you consider it ready, please press "Ready for review". Then I'll check it again and merge :) |
Member
|
Thank you and welcome as a contributor 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate_grid() creates a square [-1,1]x[-1,1] and not a unit square (which is [0,1]x[0,1]).
tiny spelling mistake in the comments on a code snippet.