make grid coloring not depend on iteration order of dicts and sets#1295
make grid coloring not depend on iteration order of dicts and sets#1295KristofferC merged 2 commits intomasterfrom
Conversation
KristofferC
force-pushed
the
kc/coloring_order
branch
from
4a42645 to
994902f
Compare
KristofferC
force-pushed
the
kc/coloring_order
branch
from
994902f to
79c0ab7
Compare
|
Ferrite tests pass now, but JET still fails on nightly. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1295 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 40 40
Lines 6750 6750
=======================================
Hits 6362 6362
Misses 388 388 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KnutAM
left a comment
KnutAM
left a comment
There was a problem hiding this comment.
LGTM.
Is there any performance difference?
| # Incidence matrix for element connections in the grid | ||
| function create_incidence_matrix(g::AbstractGrid, cellset = 1:getncells(g)) | ||
| cell_containing_node = Dict{Int, Set{Int}}() | ||
| cell_containing_node = OrderedDict{Int, Set{Int}}() |
There was a problem hiding this comment.
Is this change required? Or is it for speed?
The final incidence_matrix is unique for a given grid, so should be independent on the iteration order, right?
There was a problem hiding this comment.
Not needed, I've reverted this.
Not from what I could measure ( |
2 participants
Resolves #1261