Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
- Coverage 94.19% 89.33% -4.86%
==========================================
Files 40 40
Lines 6662 7138 +476
==========================================
+ Hits 6275 6377 +102
- Misses 387 761 +374 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KnutAM
reviewed
Nov 24, 2025
Member
KnutAM
left a comment
KnutAM
left a comment
There was a problem hiding this comment.
Just some quick comments due to slack-ping :)
Member
Author
|
This should precede #1291 . |
KnutAM
reviewed
Feb 28, 2026
termi-official
force-pushed
the
do/more-abstract-vectors
branch
from
03e4b15 to
270e73a
Compare
KnutAM
reviewed
Mar 3, 2026
3 tasks
KnutAM
approved these changes
Mar 9, 2026
Member
KnutAM
left a comment
KnutAM
left a comment
There was a problem hiding this comment.
LGTM - some optional suggestions
Member
Author
|
CodeCov is still sad and I have no clue why. It looks like I hit a codecov bug here? Should we proceed merging anyway? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows e.g. views or GPU vectors to be used.