Move test_requires to build_requirements in tests (conan-io#18929)

* move test_requires to build_requirements

* wip

* leave 1 in requirements

Author: czoido

test/functional/toolchains/microsoft/test_msbuilddeps.py

@@ -833,7 +833,7 @@ class HelloConan(ConanFile):
             settings = "os", "build_type", "compiler", "arch"
             generators = "MSBuildDeps", "MSBuildToolchain"
 
-            def requirements(self):
+            def build_requirements(self):
                 self.test_requires("mydep.pkg.team/0.1")
 
             def build(self):

test/integration/graph/test_test_requires.py

@@ -35,6 +35,9 @@ def test_test_requires_half_diamond_change_order(self):
             from conan import ConanFile
             class Pkg(ConanFile):
                 def requirements(self):
+                    # Best practice is to declare test_requires in the build_requirements() method,
+                    # but this ensures it is also possible to declare them in requirements(),
+                    # as has historically been allowed.
                     self.test_requires("gtest/1.0")
                     self.requires("zlib/1.0")
             """)
@@ -70,8 +73,9 @@ def test_test_requires_diamond_change_order(self):
         game = textwrap.dedent("""
            from conan import ConanFile
            class Pkg(ConanFile):
-               def requirements(self):
+               def build_requirements(self):
                    self.test_requires("gtest/1.0")
+               def requirements(self):
                    self.requires("engine/1.0")
            """)
         c.save({"zlib/conanfile.py": GenConanfile("zlib", "1.0"),
@@ -92,7 +96,7 @@ def test_test_requires_conflict_force(self):
         game = textwrap.dedent("""
            from conan import ConanFile
            class Pkg(ConanFile):
-               def requirements(self):
+               def build_requirements(self):
                    self.test_requires("gtest/1.0", force=True)
                    self.test_requires("rapidcheck/1.0")
            """)
@@ -214,8 +218,9 @@ class LibC(ConanFile):
             name = "libc"
             version = "0.1"
 
-            def requirements(self):
+            def build_requirements(self):
                 self.test_requires("liba/1.0")
+            def requirements(self):
                 self.requires("libb/1.0")
 
             def package_info(self):