Skip to content

Bugfix: no run names in ReportFilter. #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feyruzb wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −6
Open

Bugfix: no run names in ReportFilter. #4848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70d7fba
refactor: rewrite fix to vue3
feyruzb May 8, 2026
6535ef6
refactor: fix vue3 compatability issues of run names save pr.
feyruzb May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions web/server/vue-cli/src/components/Report/ReportFilter/Filters/BaselineRunFilter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,7 @@ defineExpose({
update: baseSelectOptionFilter.update,
registerWatchers: baseSelectOptionFilter.registerWatchers,
unregisterWatchers: baseSelectOptionFilter.unregisterWatchers,
selectedItems: baseSelectOptionFilter.selectedItems,

id,
initByUrl,
Expand Down
16 changes: 10 additions & 6 deletions web/server/vue-cli/src/components/Report/ReportFilter/ReportFilter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
</v-card>
</v-dialog>
<div>
<div
<div
class="mt-2 mb-2 d-flex align-center justify-space-between w-100 p-1"
>
<ClearAllFilters
Expand Down Expand Up @@ -503,7 +503,7 @@ const saveDialogTitle = computed(() => {

watch(() => props.refreshFilter, state => {
if (!state) return;

initByUrl();
emit("set-refresh-filter-state", false);
});
Expand Down Expand Up @@ -654,14 +654,20 @@ onBeforeUnmount(() => {
});

function saveCurrentFilter(mode) {
const activePresetId = presetMenuRef.value?.activePresetId;
const presetReportFilter = structuredClone(reportFilter.value);

// Store selected run names in reportFilter.runName (not part of the
// standard filter state, but needed for preset serialization).
const runFilter = filters.value.find(f => f.id === "run");
presetReportFilter.runName = runFilter?.selectedItems?.map(i => i.id) ?? [];

const activePresetId = presetMenuRef.value?.activePresetId;
const preset = {
id: mode === "override" && activePresetId
? activePresetId
: -1,
name: presetName.value,
reportFilter: reportFilter.value
reportFilter: presetReportFilter
};

new Promise(
Expand Down Expand Up @@ -958,7 +964,6 @@ async function getFilterPreset(preset_id) {
await router.replace({ query: nextQuery }).catch(() => {});

initByUrl();
updateUrl();
await nextTick();

if (presetMenuRef.value) {
Expand All @@ -971,7 +976,6 @@ async function clearToolbarSilently() {
unregisterWatchers();
_filters.forEach(f => f.unregisterWatchers());
await Promise.all(_filters.map(f => f.clear(false)));
updateAllFilters();
}

/*function listFilterPreset() {
Expand Down
Loading