Skip to content

Commit 4fb1181

Browse files
Apply suggestions from code review
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 460eb54 commit 4fb1181

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

src/TracedRNumber.jl

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,13 +300,15 @@ function Base.div(
300300
return div(x, y, RoundDown)
301301
end
302302
function Base.div(
303-
x::TracedRNumber{<:Reactant.ReactantSInt}, y::TracedRNumber{<:Reactant.ReactantUInt},
303+
x::TracedRNumber{<:Reactant.ReactantSInt},
304+
y::TracedRNumber{<:Reactant.ReactantUInt},
304305
::typeof(RoundToZero),
305306
)
306307
return flipsign(signed(div(unsigned(abs(x)), y)), x)
307308
end
308309
function Base.div(
309-
x::TracedRNumber{<:Reactant.ReactantSInt}, y::TracedRNumber{<:Reactant.ReactantUInt},
310+
x::TracedRNumber{<:Reactant.ReactantSInt},
311+
y::TracedRNumber{<:Reactant.ReactantUInt},
310312
::typeof(RoundDown),
311313
)
312314
ax = unsigned(abs(x))
@@ -316,7 +318,8 @@ function Base.div(
316318
return ifelse(signbit(x) & has_rem, result - one(result), result)
317319
end
318320
function Base.div(
319-
x::TracedRNumber{<:Reactant.ReactantSInt}, y::TracedRNumber{<:Reactant.ReactantUInt},
321+
x::TracedRNumber{<:Reactant.ReactantSInt},
322+
y::TracedRNumber{<:Reactant.ReactantUInt},
320323
::typeof(RoundUp),
321324
)
322325
ax = unsigned(abs(x))
@@ -326,7 +329,8 @@ function Base.div(
326329
return ifelse(!signbit(x) & has_rem, result + one(result), result)
327330
end
328331
function Base.div(
329-
x::TracedRNumber{<:Reactant.ReactantSInt}, y::TracedRNumber{<:Reactant.ReactantUInt},
332+
x::TracedRNumber{<:Reactant.ReactantSInt},
333+
y::TracedRNumber{<:Reactant.ReactantUInt},
330334
::typeof(RoundFromZero),
331335
)
332336
ax = unsigned(abs(x))

0 commit comments

Comments
 (0)