Provide a version of SvgImage that directly inherits from ImageSource

[edwwsw]

You're probably aware of this, but since SvgImage uses extension markup you can't wrap it as a key'ed ResourceDictionary resource and use that resource elsewhere.

<ResourceDictionary 
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:svg="http://sharpvectors.codeplex.com/runtime/"
    xmlns:svgc="http://sharpvectors.codeplex.com/svgc/">
...
<svgc:SvgIcon x:Key="MonitorIcon"  UriSource="Images/MonitorRun.svg"/>

Usage point

<UserControl 
    x:Class="ExampleClass"
    ...
     <Image Source="{DynamicResource MonitorIcon}" Height="24" Width="24"/>

Error message at the usage point is: The resource 'MonitorIcon' has an incompatible type.

I looked at what it would take to fix this and kind of understand why you went the extension route. Neither ImageSource nor DrawingImage can be derived from. One has a internal constructor that needs a parameter, the other class is sealed.

However, you might be able to either Directly derive a class from BitmapSource or use WritableBitmap to create a custom ImageSource. WriteableBitmap looking like it might be more appropriate.

https://learn.microsoft.com/en-us/dotnet/api/system.windows.media.imaging.writeablebitmap?view=windowsdesktop-10.0

[edwwsw]

This might have the info needed to create a custom ImageSource

https://dwayneneed.github.io/wpf/2008/06/20/implementing-a-custom-bitmapsource.html

[edwwsw]

Think I found a work around to this issue. Use a DrawingImage to render the image. Yea, not idea but I prefer this over directly embedding image references through out the code.

<DrawingImage  x:Key="MonitorIcon">
    <DrawingImage.Drawing>
        <!-- render rect size doesn't seem to matter -->
        <ImageDrawing ImageSource="{svgc:SvgImage Source=/Images/MonitorRun.svg, AppName=Themes}" Rect="0,0,100,100"/>
    </DrawingImage.Drawing>
</DrawingImage>

[paulushub]

@edwwsw SvgImage is a markup extension, SvgIcon -> SvgBitmap -> Image is an image control.

1. Controls are used directly in the XAML
2. Markup extensions are converters, and in this case DrawingGroup is the output of SvgImage. So, you need a control like the DrawingImage to render it in XAML.

You can use the convert, ResourceSvgConverter, to create ResourceDictionary of your SVG icons if use them in resource dictionary.

[edwwsw]

@paulushub

Thanks Paul,

I did a quick review of it as part of 'WpfSvgTestBox'. If I understand this tool, it is designed to convert SVG into its Xaml DrawingGroup geometry equivalent.

I'll probably continue to use my workaround as it requires less steps to integrate the graphics I received from our graphic designer. It is however nice to have ResourceSvgConverter as a backup process just in case I encounter any problems with my workaround.

You can probably close this issue out. I did even more research into ImageSources in WPF. It seems the MS team went out of their way to prevent users from creating their customized versions of ImageSource.

BTW I think I found the github repository associated with the article I linked. It has some code that creates a derived class of 'BitmapSource', I suspect it comes with its own issues.

https://github.com/barbeque/DwayneNeed

[paulushub]

@edwwsw

If I understand this tool, it is designed to convert SVG into its Xaml DrawingGroup geometry equivalent.

Yes, what is what the library does, the various converters, controls and markup extensions were added for convenience.
The different types are provided for the various use cases, your project will determine your use case.

It has some code that creates a derived class of 'BitmapSource
https://github.com/barbeque/DwayneNeed

The linked repository contains several projects. If you can specify which you meant, I will take a look.

[edwwsw]

Inside of that project there are 2 classes CustomBitmap and ChainedBitmap. CustomBitmap directly derives from BitmapSource and ChainedBitmap derives from CustomBitmap . I did not spend much time diving deeper into how these classes actually work.

https://github.com/barbeque/DwayneNeed/blob/master/Microsoft.DwayneNeed/Media/Imaging/CustomBitmap.cs
https://github.com/barbeque/DwayneNeed/blob/master/Microsoft.DwayneNeed/Media/Imaging/ChainedBitmap.cs

And BTW thanks for supporting the SharpVectors library!

[paulushub]

@edwwsw Just a reminder you can submit a PR with controls you created and wish to shared with others.