Non-atomic version of `bip_buffer_spsc_atomic` ?

[serges147]

Hello!

So far I successfully used etl::bip_buffer_spsc_atomic for BIP buffer behavior but my environment is completely single threaded (plain old super loop), single CPU core, and there is no even ISR involved. So, it would be nice to have an alternative - a bit more lighter variant of the buffer (with exactly the same public API) but without atomics inside (and so not dependent on ETL_HAS_ATOMIC).

My question (probably for maintainers):

• Should it be a new bip_buffer_spsc class/file (essentially almost full copy/paste of the atomic version but with plain size_type index fields (read, write & last)?
• OR, some efforts should be invested into trying to extract common functionality (which is a lot!) into some base class for both cases?
  Please share Your thoughts on that.

Thanks!

P.S. Maybe it's not applicable analogy, but just in case, if we look at etl::queue_spsc_xxx variants then it seems that the former approach is taken, namely copy/paste one.

[serges147]

@jwellbelove John, could you please take a look? Thank You!

[jwellbelove]

I'll try to look at this as soon as I can (but it may take a while)

[wsciaroni]

@serges147 Would an etl::circular_buffer meet your needs?

[serges147]

@wsciaroni No, it wouldn't. I need access to a range of items at once (see BIP buffer reserve/commit API), not like one by one (push & pop). More importantly these ranges of items (in my case uint8_t of raw bytes) have to be in continuous memory - this is exactly where BIP buffer shines!