From 5853c913cd1fc6a9d4028b1b2873a843b929430d Mon Sep 17 00:00:00 2001 From: Klemen <50655512+Klemen2@users.noreply.github.com> Date: Tue, 5 May 2026 18:52:29 +0200 Subject: [PATCH] fix windows icon --- apps/browser/Dioxus.toml | 3 +-- apps/browser/src/main.rs | 5 +++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/apps/browser/Dioxus.toml b/apps/browser/Dioxus.toml index 140c68127c..3d99416aea 100644 --- a/apps/browser/Dioxus.toml +++ b/apps/browser/Dioxus.toml @@ -4,8 +4,7 @@ android_main_activity = "MainActivity.kt" [bundle] publisher = "DioxusLabs" identifier = "com.dioxuslabs.blitz" -icon = ["./assets/blitz-logo.png"] +icon = ["./assets/blitz-logo.png", "./assets/blitz-logo.ico"] [bundle.windows] webview_install_mode = "Skip" -icon_path = "assets\\blitz-logo.ico" \ No newline at end of file diff --git a/apps/browser/src/main.rs b/apps/browser/src/main.rs index 297e39452c..e7ae880553 100644 --- a/apps/browser/src/main.rs +++ b/apps/browser/src/main.rs @@ -41,6 +41,8 @@ use status_bar::StatusBar; use tab::{Tab, TabId, TabStoreImplExt, TabWebView, active_tab, open_tab, tab_display_title}; use tab_strip::TabStrip; use toolbar::Toolbar; +#[cfg(target_os = "windows")] +use winit::platform::windows::WinIcon; static BROWSER_UI_STYLES: Asset = asset!("../assets/browser.css"); pub(crate) const IS_MOBILE: bool = cfg!(any(target_os = "android", target_os = "ios")); @@ -56,6 +58,9 @@ fn main() { #[cfg(feature = "tracing")] tracing_subscriber::fmt::init(); let window_attributes = WindowAttributes::default(); + #[cfg(target_os = "windows")] + let window_attributes = window_attributes + .with_window_icon(WinIcon::from_resource(32512, None).map(Into::into).ok()); #[cfg(target_os = "macos")] let window_attributes = window_attributes.with_platform_attributes(Box::new( WindowAttributesMacOS::default()