Skip to content

Commit 72a021a

Browse files
authored
ci: add allow_failure to all manual jobs to prevent pipeline hanging (#3649)
Manual jobs without allow_failure block pipeline completion by default. This causes pipelines to stay in "running" state indefinitely even when all actual jobs have completed, because GitLab waits for manual jobs to be triggered. Added allow_failure: true to all manual jobs: - CI image builds (CentOS, Alpine, Bookworm, Buster) - Benchmarks (tracer, profiling, appsec) - Macrobenchmarks - Package deployment jobs - AppSec docker image pushes - Tested versions collection Also added allow_failure to the deploy_to_reliability_env trigger job to prevent hanging when downstream pipelines don't complete. This allows pipelines to complete successfully while keeping manual jobs available for optional execution.
1 parent c31cf60 commit 72a021a

File tree

5 files changed

+15
-0
lines changed

5 files changed

+15
-0
lines changed

.gitlab/benchmarks.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,10 @@ workflow:
3333
interruptible: true
3434
- if: $CI_COMMIT_REF_NAME == "master"
3535
when: manual
36+
allow_failure: true
3637
interruptible: false
3738
- when: manual
39+
allow_failure: true
3840
interruptible: true
3941

4042
.benchmarks-appsec-rules: &benchmarks-appsec-rules
@@ -54,8 +56,10 @@ workflow:
5456
interruptible: true
5557
- if: $CI_COMMIT_REF_NAME == "master"
5658
when: manual
59+
allow_failure: true
5760
interruptible: false
5861
- when: manual
62+
allow_failure: true
5963
interruptible: true
6064

6165
.benchmarks-tracer-rules: &benchmarks-tracer-rules
@@ -67,8 +71,10 @@ workflow:
6771
interruptible: true
6872
- if: $CI_COMMIT_REF_NAME == "master"
6973
when: manual
74+
allow_failure: true
7075
interruptible: false
7176
- when: manual
77+
allow_failure: true
7278
interruptible: true
7379

7480
.on-master-or-nightly-benchmarks-or-release-always-and-not-interruptible: &on-master-or-nightly-benchmarks-or-release-always-and-not-interruptible
@@ -79,6 +85,7 @@ workflow:
7985
.macrobenchmarks-rules: &macrobenchmarks-rules
8086
- <<: *on-master-or-nightly-benchmarks-or-release-always-and-not-interruptible
8187
- when: manual
88+
allow_failure: true
8289
interruptible: true
8390

8491
.pre-release-performance-quality-gates-rules: &pre-release-performance-quality-gates-rules

.gitlab/ci-images.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ CentOS:
1212
stage: ci-build
1313
rules:
1414
- when: manual
15+
allow_failure: true
1516
needs: []
1617
tags: ["arch:amd64"]
1718
timeout: 4h
@@ -40,6 +41,7 @@ Alpine:
4041
stage: ci-build
4142
rules:
4243
- when: manual
44+
allow_failure: true
4345
needs: []
4446
tags: ["arch:amd64"]
4547
timeout: 4h
@@ -68,6 +70,7 @@ Bookworm:
6870
stage: ci-build
6971
rules:
7072
- when: manual
73+
allow_failure: true
7174
needs: []
7275
tags: ["arch:amd64"]
7376
timeout: 4h
@@ -98,6 +101,7 @@ Buster:
98101
stage: ci-build
99102
rules:
100103
- when: manual
104+
allow_failure: true
101105
needs: []
102106
tags: ["arch:amd64"]
103107
timeout: 4h

.gitlab/generate-appsec.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,7 @@
241241
- ARCH: ["amd64", "arm64"]
242242
rules:
243243
- when: manual
244+
allow_failure: true
244245
needs: []
245246
script:
246247
- cd appsec/tests/integration

.gitlab/generate-package.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1364,6 +1364,7 @@
13641364
- if: $CI_COMMIT_REF_NAME == "master" && $CI_PIPELINE_SOURCE != "schedule"
13651365
when: on_success
13661366
- when: manual
1367+
allow_failure: true
13671368
needs:
13681369
- job: "prepare code"
13691370
artifacts: true
@@ -1436,6 +1437,7 @@
14361437

14371438
deploy_to_reliability_env:
14381439
stage: shared-pipeline
1440+
allow_failure: true
14391441
needs:
14401442
- job: "bundle for reliability env"
14411443
rules:

.gitlab/generate-tracer.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -767,3 +767,4 @@ function before_script_steps($with_docker_auth = false) {
767767
- if: $CI_COMMIT_REF_NAME == "master"
768768
when: always
769769
- when: manual
770+
allow_failure: true

0 commit comments

Comments
 (0)