libdatadog update to efbbf4c1 [no-ci-feedback]

Automated update by CI pipeline https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/135100943

Full CI result: ❌ 176 job(s) failed

Author: github-actions[bot]

components-rs/sidecar.rs

@@ -65,31 +65,40 @@ pub extern "C" fn ddog_sidecar_enable_appsec(
     log_level: CharSlice,
 ) -> () {
     let mut appsec_config_guard = APPSEC_CONFIG.lock().unwrap();
-    let shared_lib_path_os: std::ffi::OsString;
-    let socket_file_path_os: std::ffi::OsString;
-    let lock_file_path_os: std::ffi::OsString;
     let log_file_path_os: std::ffi::OsString;
 
     #[cfg(unix)]
     {
-        shared_lib_path_os = OsStr::from_bytes(shared_lib_path.as_bytes()).to_owned();
-        socket_file_path_os = OsStr::from_bytes(socket_file_path.as_bytes()).to_owned();
-        lock_file_path_os = OsStr::from_bytes(lock_file_path.as_bytes()).to_owned();
         log_file_path_os = OsStr::from_bytes(log_file_path.as_bytes()).to_owned();
     }
 
     #[cfg(windows)]
     {
-        shared_lib_path_os = OsStr::new(&*shared_lib_path.to_utf8_lossy()).to_owned();
-        socket_file_path_os = OsStr::new(&*socket_file_path.to_utf8_lossy()).to_owned();
-        lock_file_path_os = OsStr::new(&*lock_file_path.to_utf8_lossy()).to_owned();
         log_file_path_os = OsStr::new(&*log_file_path.to_utf8_lossy()).to_owned();
     }
 
+    // libdatadog dropped `AppSecConfig::{shared_lib_path, socket_file_path,
+    // lock_file_path}` (libdatadog#2310). The sidecar no longer loads the
+    // helper as a shared library dependency, no longer calls its
+    // `appsec_helper_main`/`appsec_helper_shutdown` entry points, and no longer
+    // forwards the socket/lock paths to the daemon's environment. It instead
+    // expects an in-process `AppSecBackend` registered through
+    // `datadog_sidecar::appsec::register_backend_factory`, with requests routed
+    // over the sidecar transport via `ddog_sidecar_send_appsec_message`.
+    //
+    // dd-trace-php has not been ported to that model yet, so these three paths
+    // have nowhere to go and the helper will not be started for us. The
+    // remaining fields are still honoured, so keep publishing the config: it is
+    // what makes the sidecar attempt to bring appsec up at all.
+    warn!(
+        "This libdatadog no longer starts the appsec helper on the tracer's \
+         behalf; appsec will be unavailable (helper {}, socket {}, lock {})",
+        shared_lib_path.to_utf8_lossy(),
+        socket_file_path.to_utf8_lossy(),
+        lock_file_path.to_utf8_lossy(),
+    );
+
     appsec_config_guard.deref_mut().replace(AppSecConfig {
-        shared_lib_path: shared_lib_path_os,
-        socket_file_path: socket_file_path_os,
-        lock_file_path: lock_file_path_os,
         log_file_path: log_file_path_os,
         log_level: log_level.to_utf8_lossy().to_string(),
     });