post gloas, we're selecting the current attestation but also seem to have stale attestations that we can select and include in blocks, that are identical by signature.
Because there's no unique votes we shouldnt be re-including these.
it's simple to reproduce, start a gloas minimal with 4 teku nodes, and within 1-2 epochs of gloas you'll see blocks including multiple attestations. several per epoch are attestations from older blocks. eg. if the attestation was slot 24, check slot 25 and see if the signature matches. if the signature matches we shouldnt have included it in the block (probably a filter broken somewhere)
post gloas, we're selecting the current attestation but also seem to have stale attestations that we can select and include in blocks, that are identical by signature.
Because there's no unique votes we shouldnt be re-including these.
it's simple to reproduce, start a gloas minimal with 4 teku nodes, and within 1-2 epochs of gloas you'll see blocks including multiple attestations. several per epoch are attestations from older blocks. eg. if the attestation was slot 24, check slot 25 and see if the signature matches. if the signature matches we shouldnt have included it in the block (probably a filter broken somewhere)