slide section: select slides on clicking header

now clicking on the section header,
user can select all the slides in the section

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I08003e8dab460a2ac7f700b2856ed3155e1c970c

Author: lpranam

browser/src/control/Control.PartsPreview.js

@@ -565,6 +565,15 @@ window.L.Control.PartsPreview = window.L.Control.extend({
 			that._toggleSectionCollapse(sectionIndex);
 		}, this);
 
+		// Click on the header (but not the toggle) selects all slides in the section.
+		window.L.DomEvent.on(header, 'click', function (e) {
+			if (toggleBtn.contains(e.target))
+				return;
+			window.L.DomEvent.stopPropagation(e);
+			window.L.DomEvent.preventDefault(e);
+			that._selectSection(sectionIndex);
+		}, this);
+
 		// Section context menu
 		if (this._map.isEditMode()) {
 			window.L.DomEvent.on(header, 'contextmenu', function(e) {
@@ -581,6 +590,22 @@ window.L.Control.PartsPreview = window.L.Control.extend({
 		return header;
 	},
 
+	_selectSection: function (sectionIndex) {
+		var sections = app.impress && app.impress.sections;
+		if (!sections || !sections[sectionIndex])
+			return;
+
+		var start = sections[sectionIndex].startIndex;
+		var end = (sectionIndex + 1 < sections.length)
+			? sections[sectionIndex + 1].startIndex - 1
+			: this._previewTiles.length - 1;
+
+		if (start < 0 || end < start)
+			return;
+
+		this._selectPartRange(start, end, false);
+	},
+
 	_toggleSectionCollapse: function (sectionIndex) {
 		var sections = app.impress.sections || [];
 		var section = sections[sectionIndex];
@@ -894,7 +919,7 @@ window.L.Control.PartsPreview = window.L.Control.extend({
 		}
 	},
 
-	_selectPartRange: function (start, end) {
+	_selectPartRange: function (start, end, scrollToEnd = true) {
 		if (start === undefined || start === null)
 			start = this._map._docLayer._selectedPart;
 
@@ -919,7 +944,8 @@ window.L.Control.PartsPreview = window.L.Control.extend({
 			}
 		}
 		this._selectedPartRange = [start, end];
-		this._scrollToPart(end);
+		if (scrollToEnd)
+			this._scrollToPart(end);
 	},
 
 	_modifySelectedPartRange: function (direction) {

cypress_test/integration_tests/desktop/impress/slide_sections_spec.js

@@ -1,5 +1,5 @@
 /* -*- js-indent-level: 8 -*- */
-/* global describe it cy require beforeEach */
+/* global describe it cy require beforeEach expect */
 
 var helper = require('../../common/helper');
 var desktopHelper = require('../../common/desktop_helper');
@@ -115,6 +115,30 @@ describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'Slide sections', function(
 			assertSectionHeaders(['Section-2', 'Section-1', 'Section-3']);
 		});
 
+		it('Section slide selection', function() {
+			helper.processToIdle(this.win);
+
+			// 3 sections: Section-1 (slides 1-4), Section-2 (5-11), Section-3 (12-13).
+			assertSectionHeaders(['Section-1', 'Section-2', 'Section-3']);
+
+			// Click the body of Section-2's header (anywhere that isn't the toggle).
+			cy.cGet('.slide-section-header').eq(1)
+				.find('.slide-section-name').click();
+			helper.processToIdle(this.win);
+
+			cy.window().then((win) => {
+				var impress = win['0'].app.impress;
+				// Slides in Section-2 (indices 4-10) should be selected.
+				for (var i = 4; i <= 10; i++)
+					expect(impress.isSlideSelected(i)).to.be.true;
+
+				// Slides outside Section-2 should not be selected.
+				[0, 1, 2, 3, 11, 12].forEach(function (i) {
+					expect(impress.isSlideSelected(i)).to.be.false;
+				});
+			});
+		});
+
 		it('Collapse section hides its slides', function() {
 			helper.processToIdle(this.win);