Skip to content

Commit fbf2439

Browse files
committed
Further consistency between workflows
1 parent cd7e7a5 commit fbf2439

4 files changed

Lines changed: 24 additions & 10 deletions

File tree

.github/workflows/test_suite_ubuntu_cpu_gnu.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,21 @@ on:
1010
# Triggers the workflow on pushes to open pull requests with code changes
1111
pull_request:
1212
paths:
13+
# This workflow
1314
- '.github/workflows/test_suite_ubuntu_cpu_gnu.yml'
15+
# Source files
1416
- '**.c'
1517
- '**.cpp'
1618
- '**.fypp'
1719
- '**.f90'
1820
- '**.F90'
19-
- '**.pf'
2021
- '**.py'
21-
- '**.sh'
22+
# Unit tests
23+
- '**.pf'
24+
# Build system
2225
- '**CMakeLists.txt'
2326
- '**requirements.txt'
27+
# Data
2428
- '**data/*'
2529

2630
# Allows you to run this workflow manually from the Actions tab
@@ -155,10 +159,10 @@ jobs:
155159
-DCMAKE_Fortran_COMPILER=gfortran \
156160
-DCMAKE_C_COMPILER=gcc \
157161
-DCMAKE_CXX_COMPILER=g++ \
158-
-DCMAKE_INSTALL_PREFIX=${BUILD_DIR} \
162+
-DCMAKE_INSTALL_PREFIX="${BUILD_DIR}" \
159163
-DCMAKE_BUILD_TESTS=TRUE \
160164
-DCMAKE_PREFIX_PATH="${PFUNIT_DIR};${Torch_DIR}" \
161-
-DCMAKE_Fortran_FLAGS="-std=$FORTRAN_STANDARD"
165+
-DCMAKE_Fortran_FLAGS="-std=${FORTRAN_STANDARD}"
162166
cmake --build .
163167
cmake --install .
164168

.github/workflows/test_suite_ubuntu_cpu_intel.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ jobs:
4444
- toolchain: intel-ifort
4545
FC: ifort
4646
MPIFC: mpiifort
47+
std: [f08]
4748

4849
# Steps represent a sequence of tasks that will be executed as part of the job
4950
steps:
@@ -92,6 +93,8 @@ jobs:
9293
make -j 4 install
9394
9495
- name: Build and install FTorch
96+
env:
97+
FORTRAN_STANDARD: ${{ matrix.std }}
9598
run: |
9699
. ftorch/bin/activate
97100
VN=$(python -c "import sys; print('.'.join(sys.version.split('.')[:2]))")
@@ -109,10 +112,10 @@ jobs:
109112
-DCMAKE_CXX_COMPILER=icpx \
110113
-DCMAKE_Fortran_COMPILER=${{ matrix.FC }} \
111114
-DMPI_Fortran_COMPILER=${{ matrix.MPIFC }} \
112-
-DCMAKE_INSTALL_PREFIX=${BUILD_DIR} \
115+
-DCMAKE_INSTALL_PREFIX="${BUILD_DIR}" \
113116
-DCMAKE_BUILD_TESTS=TRUE \
114117
-DCMAKE_PREFIX_PATH="${PFUNIT_DIR};${Torch_DIR}" \
115-
-DCMAKE_Fortran_FLAGS="-stand f08"
118+
-DCMAKE_Fortran_FLAGS="${FORTRAN_STANDARD}"
116119
cmake --build .
117120
cmake --install .
118121

.github/workflows/test_suite_ubuntu_cuda_gnu.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88
push:
99
branches: [ "main" ]
1010
paths:
11+
# This workflow
1112
- '.github/workflows/test_suite_ubuntu_cuda_gnu.yml'
1213
# Library source files
1314
- 'src/*.fypp'
@@ -97,6 +98,8 @@ jobs:
9798
make -j 4 install
9899
99100
- name: Build FTorch
101+
env:
102+
FORTRAN_STANDARD: f2008
100103
run: |
101104
. ftorch/bin/activate
102105
VN=$(python -c "import sys; print('.'.join(sys.version.split('.')[:2]))")
@@ -109,12 +112,12 @@ jobs:
109112
cmake .. \
110113
-DPython_EXECUTABLE="$(which python)" \
111114
-DCMAKE_BUILD_TYPE=Release \
112-
-DCMAKE_INSTALL_PREFIX=${BUILD_DIR} \
115+
-DCMAKE_INSTALL_PREFIX="${BUILD_DIR}" \
113116
-DCMAKE_BUILD_TESTS=TRUE \
114117
-DGPU_DEVICE=CUDA \
115118
-DMULTI_GPU=OFF \
116119
-DCMAKE_PREFIX_PATH="${PFUNIT_DIR};${Torch_DIR}" \
117-
-DCMAKE_Fortran_FLAGS="-std=f2008"
120+
-DCMAKE_Fortran_FLAGS="-std=${FORTRAN_STANDARD}"
118121
cmake --build .
119122
cmake --install .
120123

.github/workflows/test_suite_windows_cpu_intel.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,21 @@ on:
1111
# # Triggers the workflow on pushes to open pull requests with code changes
1212
# pull_request:
1313
# paths:
14+
# # This workflow
1415
# - '.github/workflows/test_suite_windows_cpu_intel.yml'
15-
# - '**.bat'
16+
# # Source files
1617
# - '**.c'
1718
# - '**.cpp'
1819
# - '**.fypp'
1920
# - '**.f90'
2021
# - '**.F90'
21-
# - '**.pf'
2222
# - '**.py'
23+
# # Unit tests
24+
# - '**.pf'
25+
# # Build system
2326
# - '**CMakeLists.txt'
2427
# - '**requirements.txt'
28+
# # Data
2529
# - '**data/*'
2630

2731
# Allows you to run this workflow manually from the Actions tab

0 commit comments

Comments
 (0)