Batsad 1440 (#26)

* acl private no longer needed

* variablize slack channel id

Author: dgwhited

s3_data_events/s3.tf

@@ -4,10 +4,6 @@ resource "aws_s3_bucket" "cloudtrail" {
   force_destroy = false
 }
 
-resource "aws_s3_bucket_acl" "cloudtrail" {
-  bucket = aws_s3_bucket.cloudtrail.id
-  acl    = "private"
-}
 
 resource "aws_s3_bucket_public_access_block" "cloudtrail" {
   bucket = aws_s3_bucket.cloudtrail.id

security-alerts/chatbot.tf

@@ -1,7 +1,7 @@
 resource "awscc_chatbot_slack_channel_configuration" "chatbot" {
   configuration_name = "batcave-security-alerts"
   iam_role_arn       = aws_iam_role.chatbot_role.arn
-  slack_channel_id   = "C036GQ3E9D1"
+  slack_channel_id   = var.slack_channel_id
   slack_workspace_id = "TGYJGRB1T"
   guardrail_policies = ["arn:aws:iam::aws:policy/ReadOnlyAccess"]
   logging_level      = "INFO"

security-alerts/variables.tf

@@ -25,4 +25,9 @@ variable "sechub_nessus_rule_name" {
 
 variable "account_name" {
   type = string
+}
+
+variable "slack_channel_id" {
+  type    = string
+  default = "C036GQ3E9D1"
 }