From ae97700a5cc6b6cb2c27a0053c1f4a284f0f236e Mon Sep 17 00:00:00 2001 From: Samuel Letellier-Duchesne Date: Mon, 11 May 2026 10:11:27 -0400 Subject: [PATCH] Fix case-sensitive section-name match in sim settings loader MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `BaseSimSettings.update_from_config` lowercases the section name from the config file but compares it against a list that contains the literal 'Generic Simulation Settings'. As a result, settings under the [Generic Simulation Settings] section were silently skipped, and mandatory settings declared there (e.g. weather_file_path) were never populated — triggering a misleading "not specified" error at run time. Lowercase the literal so the comparison is case-insensitive on both sides. --- bim2sim/sim_settings.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bim2sim/sim_settings.py b/bim2sim/sim_settings.py index ffaba75a2e..984fd2e1b5 100644 --- a/bim2sim/sim_settings.py +++ b/bim2sim/sim_settings.py @@ -276,7 +276,7 @@ def update_from_config(self, config): # don't load settings which are not simulation relevant if cat.lower() not in [ self.__class__.__name__.lower(), - 'Generic Simulation Settings' + 'generic simulation settings' ]: continue cat_from_cfg = config[cat]