Merge: eslint cleanup (remove all disables)

Axmouth · Axmouth · commit b7745f693e73 · 2026-06-24T01:49:57.000+03:00
diff --git a/FOLLOWUPS.md b/FOLLOWUPS.md
@@ -324,7 +324,12 @@ Cronicle's foundation (Node runtime, bespoke flat-file storage) is weaker than a
   action (§3); a richer retry editor (form sends no retry override yet).
 - `[DONE]` Same-name job warning on create/edit (JobForm warns inline and confirms before
   saving a duplicate name).
-- `[PLANNED]` Lint cleanup (e.g. the `react-refresh/only-export-components` disables).
+- `[DONE]` Lint cleanup: removed all `eslint-disable` comments. `router` (was a dead
+  `AppRouter` + a flagged const) is now just the exported router; `useAuth`/the auth context
+  moved to `auth/useAuth.ts` so `AuthContext.tsx` exports only the provider; `WorkersPage`
+  uses a ticking `now` state instead of `Date.now()` in render. `eslint .` is clean.
+- `[PLANNED]` UI polish pass: restyle pages toward samples/descriptions the user will
+  provide (look/feel, layout, components). Awaiting those references before starting.
 
 ## 10. CI / Docker follow-ups
 
diff --git a/ui_dist/assets/index-CSZCiq63.js.map b/ui_dist/assets/index-CSZCiq63.js.map
diff --git a/ui_dist/assets/index-CuzEjnUA.js b/ui_dist/assets/index-CuzEjnUA.js
diff --git a/ui_dist/assets/index-CuzEjnUA.js.map b/ui_dist/assets/index-CuzEjnUA.js.map
diff --git a/ui_dist/index.html b/ui_dist/index.html
@@ -5,7 +5,7 @@
     <link rel="icon" type="image/svg+xml" href="/logo.svg" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Nexus Arbiter</title>
-    <script type="module" crossorigin src="/assets/index-CSZCiq63.js"></script>
+    <script type="module" crossorigin src="/assets/index-CuzEjnUA.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-BZkqKtOk.css">
   </head>
   <body>
diff --git a/web-ui/src/App.tsx b/web-ui/src/App.tsx
@@ -1,6 +1,7 @@
 import { RouterProvider } from '@tanstack/react-router'
 import { router } from './router'
-import { AuthProvider, useAuth } from './auth/AuthContext.tsx'
+import { AuthProvider } from './auth/AuthContext'
+import { useAuth } from './auth/useAuth'
 
 function InnerApp() {
   const auth = useAuth()
diff --git a/web-ui/src/auth/AuthContext.tsx b/web-ui/src/auth/AuthContext.tsx
@@ -1,24 +1,11 @@
-import { createContext, useContext, useEffect, useState } from 'react'
-import type { User } from '../backend-types'
+import { useEffect, useState } from 'react'
 import {
   me as fetchMe,
   login as apiLogin,
   logout as apiLogout,
 } from '../api/auth'
 import { redirect } from '@tanstack/react-router'
-
-export type AuthState =
-  | { status: 'loading'; user: null }
-  | { status: 'unauthenticated'; user: null }
-  | { status: 'authenticated'; user: User }
-
-export type AuthContextValue = {
-  state: AuthState
-  login: (username: string, password: string) => Promise<void>
-  logout: () => Promise<void>
-}
-
-const AuthContext = createContext<AuthContextValue | undefined>(undefined)
+import { AuthContext, type AuthState } from './useAuth'
 
 export function AuthProvider({ children }: { children: React.ReactNode }) {
   const [state, setState] = useState<AuthState>({
@@ -50,11 +37,3 @@ export function AuthProvider({ children }: { children: React.ReactNode }) {
     </AuthContext.Provider>
   )
 }
-
-// TODO: ?
-// eslint-disable-next-line react-refresh/only-export-components
-export function useAuth() {
-  const ctx = useContext(AuthContext)
-  if (!ctx) throw new Error('useAuth must be used inside AuthProvider')
-  return ctx
-}
diff --git a/web-ui/src/auth/useAuth.ts b/web-ui/src/auth/useAuth.ts
@@ -0,0 +1,21 @@
+import { createContext, useContext } from 'react'
+import type { User } from '../backend-types'
+
+export type AuthState =
+  | { status: 'loading'; user: null }
+  | { status: 'unauthenticated'; user: null }
+  | { status: 'authenticated'; user: User }
+
+export type AuthContextValue = {
+  state: AuthState
+  login: (username: string, password: string) => Promise<void>
+  logout: () => Promise<void>
+}
+
+export const AuthContext = createContext<AuthContextValue | undefined>(undefined)
+
+export function useAuth() {
+  const ctx = useContext(AuthContext)
+  if (!ctx) throw new Error('useAuth must be used inside AuthProvider')
+  return ctx
+}
diff --git a/web-ui/src/layout/AppLayout.tsx b/web-ui/src/layout/AppLayout.tsx
@@ -1,5 +1,5 @@
 import { Link } from '@tanstack/react-router'
-import { useAuth } from '../auth/AuthContext'
+import { useAuth } from '../auth/useAuth'
 import DarkmodeToggle from '../components/DarkmodeToggle'
 import { useEffect, useState } from 'react'
 import { ConfigProvider, theme as antdTheme } from 'antd'
diff --git a/web-ui/src/pages/LoginPage.tsx b/web-ui/src/pages/LoginPage.tsx
@@ -1,5 +1,5 @@
 import { type FormEvent, useEffect, useState } from 'react'
-import { useAuth } from '../auth/AuthContext'
+import { useAuth } from '../auth/useAuth'
 import { useNavigate, useRouter } from '@tanstack/react-router'
 import type { ApiResponse } from '../backend-types'
 
diff --git a/web-ui/src/pages/TenantsPage.tsx b/web-ui/src/pages/TenantsPage.tsx
@@ -2,7 +2,7 @@ import { useState } from 'react'
 import { useMutation, useQueryClient } from '@tanstack/react-query'
 import { useTenants } from '../hooks/useTenants'
 import { createTenant } from '../api/tenants'
-import { useAuth } from '../auth/AuthContext'
+import { useAuth } from '../auth/useAuth'
 import { SlideOver } from '../components/SlideOver'
 import { formatTime } from '../utils/time'
 
diff --git a/web-ui/src/pages/UsersPage.tsx b/web-ui/src/pages/UsersPage.tsx
@@ -2,7 +2,7 @@ import { useState } from 'react'
 import { useMutation, useQueryClient } from '@tanstack/react-query'
 import { useUsers } from '../hooks/useUsers'
 import { useTenants } from '../hooks/useTenants'
-import { useAuth } from '../auth/AuthContext'
+import { useAuth } from '../auth/useAuth'
 import { createUser, deleteUser, updateUser } from '../api/users'
 import { SlideOver } from '../components/SlideOver'
 import { formatTime } from '../utils/time'
diff --git a/web-ui/src/pages/WorkersPage.tsx b/web-ui/src/pages/WorkersPage.tsx
@@ -1,7 +1,15 @@
+import { useEffect, useState } from 'react'
 import { useWorkers } from '../hooks/useWorkers'
 
 export function WorkersPage() {
   const { data: workers, isLoading, error } = useWorkers()
+  // A ticking clock so "online/offline" stays current without reading Date.now() during
+  // render (which is impure). Refreshes every 5s.
+  const [now, setNow] = useState(() => Date.now())
+  useEffect(() => {
+    const id = setInterval(() => setNow(Date.now()), 5000)
+    return () => clearInterval(id)
+  }, [])
 
   return (
     <div className="space-y-6">
@@ -48,7 +56,7 @@ export function WorkersPage() {
                   <td className="px-4 py-2">{w.version}</td>
                   <td className="px-4 py-2">{w.capacity}</td>
                   <td className="px-4 py-2">
-                    <WorkerStatus lastSeen={w.lastSeen} />
+                    <WorkerStatus lastSeen={w.lastSeen} now={now} />
                   </td>
                 </tr>
               ))}
@@ -64,11 +72,10 @@ function formatTime(t: string) {
   return new Date(t).toLocaleString()
 }
 
-function WorkerStatus({ lastSeen }: { lastSeen: string }) {
-  // TODO: Can it be better?
-  // eslint-disable-next-line react-hooks/purity
-  const delta = Date.now() - new Date(lastSeen).getTime()
-  const alive = delta < 20_000 // 10 seconds threshold
+function WorkerStatus({ lastSeen, now }: { lastSeen: string; now: number }) {
+  // `now` is a ticking value from the parent, so this stays a pure render.
+  const delta = now - new Date(lastSeen).getTime()
+  const alive = delta < 20_000 // 20 seconds threshold
 
   return (
     <span
diff --git a/web-ui/src/router.tsx b/web-ui/src/router.tsx
@@ -1,10 +1,9 @@
-import { createRouter, RouterProvider } from '@tanstack/react-router'
+import { createRouter } from '@tanstack/react-router'
 import { jobsRoute } from './routes/jobs'
 import { runsRoute } from './routes/runs'
 import { rootRoute } from './routes/root'
 import { workersRoute } from './routes/workers'
 import { loginRoute } from './routes/login'
-import { useAuth } from './auth/AuthContext'
 import { homeRoute } from './routes/home'
 import { secretsRoute } from './routes/secrets'
 import { configsRoute } from './routes/configs'
@@ -29,16 +28,9 @@ declare module '@tanstack/react-router' {
   }
 }
 
-// eslint-disable-next-line react-refresh/only-export-components
 export const router = createRouter({
   routeTree,
   context: {
     auth: undefined!,
   },
 })
-
-export function AppRouter() {
-  const auth = useAuth()
-
-  return <RouterProvider router={router} context={{ auth }} />
-}
diff --git a/web-ui/src/routes/topComponent.tsx b/web-ui/src/routes/topComponent.tsx
@@ -1,7 +1,7 @@
 import { Outlet, useNavigate } from '@tanstack/react-router'
 import { AppLayout } from '../layout/AppLayout'
 import { publicRoutes } from '../router/publicRoutes'
-import { useAuth } from '../auth/AuthContext'
+import { useAuth } from '../auth/useAuth'
 
 export const TopComponent = () => {
   const auth = useAuth()
