tests/php/readme.md only documents the monorepo workflow, so the suite looks unrunnable from a standalone clone

[donnchawp]

tests/php/readme.md documents running the tests from inside the Jetpack monorepo only:

1. Run jetpack install plugins/crm
2. Go to the crm plugins directory projects/plugins/crm
3. Run composer run-script phpunit

None of that applies to a standalone clone of this repo, which is how it ships and what make up sets up. make test runs composer phpunit, which needs a WordPress test library the readme never mentions, so the first thing you hit is a fatal about a missing wp-settings.php.

The test library is already there. make up starts wp-env, and its tests container ships the WordPress test suite at /wordpress-phpunit with the plugin mounted, so the whole suite runs with one command:

docker exec -w /var/www/html/wp-content/plugins/jetpack-crm zero-bs-crm-tests-cli-1 \
  sh -c 'WORDPRESS_DEVELOP_DIR=/wordpress-phpunit php vendor/bin/phpunit -c phpunit.12.xml.dist'

Worth documenting, along with a few things that took a while to work out:

• composer phpunit does not work inside the container. It calls vendor/bin/phpunit-select-config, which uses pcntl_exec, and that isn't available there. Call vendor/bin/phpunit directly with the config matching your PHPUnit version.
• phpunit.12.xml.dist is a symlink to phpunit.11.xml.dist. If you are adding a <testsuite> and dutifully edit "both", you write the same file twice and end up with a duplicated block.
• WP_Ajax_UnitTestCase puts its tests in the ajax group, which the WordPress bootstrap excludes unless you pass --group ajax. Tests written on it are silently skipped, so a suite that never runs still reports green.
• wp_send_json() only sets a status code when headers_sent() is false, which it never is under PHPUnit. Asserting on a handler's response status passes regardless of what the handler decided, so those assertions are worth nothing. Assert on the body instead.

make lint has the same gap. composer cs shells out to phpcs-changed, which isn't in require-dev and isn't vendored, and there's no vendor/bin/phpcs either, so linting can't be run from a standalone clone at all. Either add the dependency or say plainly in the readme that linting is monorepo-only.

Happy to send a PR if the direction looks right.

[donnchawp]

#36 landed and resolved parts of this. What is left is the part the title names, so this stays open. Striking through what no longer applies:

Fixed:

• make test works from a standalone clone. It runs inside the wp-env tests-cli container with WORDPRESS_DEVELOP_DIR=/wordpress-phpunit, which is the same test library the docker exec line above reaches, wrapped in a command you can actually remember. It takes phpunit flags through ARGS.
• composer phpunit no longer dies on pcntl_exec inside the container. It reads the major version out of phpunit --version and picks the config itself rather than shelling through phpunit-select-config.
• make lint works from a standalone clone. phpcs, WPCS and phpcs-changed are in require-dev, and the ruleset that went missing in 469d432 is back. That was make lint reports "No changes found." when phpcs-changed is not installed #23.

Still true:

• tests/php/readme.md is unchanged. It still opens with "The monorepo relies on the test-php Composer script" and still tells you to run jetpack install plugins/crm from projects/plugins/crm. Make the local lint and test commands work #36 documented make test and make lint in the root README.md instead, so the repo now says two different things about running its tests, and the stale one is the file sitting in the test directory. That is worse than before, when it was merely out of date.
• phpunit.12.xml.dist is still a symlink to phpunit.11.xml.dist, so adding a <testsuite> to "both" writes the same file twice. Worth a line, because the mistake is invisible until someone reads the diff.
• The ajax group trap is still undocumented. WP_Ajax_UnitTestCase puts its tests in a group the WordPress bootstrap excludes unless you pass --group ajax, so a suite written on it reports green having never run. Carried over from make test cannot locate WordPress outside the monorepo, and the readme does not cover it #24, which is closed now.
• wp_send_json() only sets a status code when headers_sent() is false, which never holds under PHPUnit, so asserting on a handler's response status passes whatever the handler decided. Assert on the body.

So this is now a documentation issue and nothing else: rewrite tests/php/readme.md for the standalone clone, point at make test, and carry the four traps above. The root README.md is the model to be consistent with rather than to duplicate.