refactor: add more properties to func node

Author: AlbertoCentonze

natrix/ast_node.py

@@ -176,6 +176,26 @@ def modifiers(self) -> List[str]:
             if "id" in decorator
         ]
 
+    @cached_property
+    def is_runtime_code(self) -> bool:
+        return not (self.is_constructor or self.is_from_interface)
+
+    @cached_property
+    def is_external(self) -> bool:
+        """
+        Check if the function is external by looking for the 'external' modifier.
+        """
+        return "external" in self.modifiers
+
+    @cached_property
+    def is_internal(self) -> bool:
+        """
+        Check if the function is internal by looking for the 'internal' modifier.
+        """
+        return "internal" in self.modifiers or not (
+            "external" in self.modifiers or self.is_runtime_code
+        )
+
     @cached_property
     def memory_accesses(self) -> List[MemoryAccess]:
         """

natrix/rules/implicit_internal.py

@@ -21,10 +21,14 @@ def __init__(self):
         )
 
     def visit_FunctionDef(self, node: FunctionDefNode):
+        print(f"Checking function: {node.get('name')}")
+        print(f"{node.is_runtime_code=}")
+        print(f"{node.is_external=}")
         if (
-            node.is_constructor
-            or node.is_from_interface
-            or "external" in node.modifiers
+            # not an internal function
+            not node.is_runtime_code
+            or node.is_external
+            # explicit internal
             or "internal" in node.modifiers
         ):
             return