Make application_name writable

Author: gcatanese

lib/adyen/client.rb

@@ -12,7 +12,7 @@
 
 module Adyen
   class Client
-    attr_accessor :ws_user, :ws_password, :api_key, :oauth_token, :client, :adapter
+    attr_accessor :ws_user, :ws_password, :api_key, :oauth_token, :client, :adapter, :application_name
     attr_reader :env, :connection_options, :adapter_options, :terminal_region
 
     def initialize(ws_user: nil, ws_password: nil, api_key: nil, oauth_token: nil, env: :live, adapter: nil, mock_port: 3001,
@@ -155,7 +155,7 @@ def call_adyen_api(service, action, request_data, headers, version, _with_applic
         faraday.adapter @adapter, **@adapter_options
         faraday.headers['Content-Type'] = 'application/json'
         user_agent = "#{Adyen::NAME}/#{Adyen::VERSION}"
-        user_agent = "#{@application_name} #{user_agent}" unless @application_name.nil? || @application_name.empty?
+        user_agent = "#{@application_name} #{user_agent}" if @application_name && !@application_name.strip.empty?
         faraday.headers['User-Agent'] = user_agent
 
         # set header based on auth_type and service

spec/client_spec.rb

@@ -502,4 +502,32 @@
     expect(connection_headers['User-Agent']).to_not be_empty
     expect(connection_headers['User-Agent']).to eq("MyTestApp #{Adyen::NAME}/#{Adyen::VERSION}")
   end
-end
+
+  it 'ensures User-Agent includes application_name when set after initialization' do
+    client = Adyen::Client.new
+    client.api_key = 'api_key'
+    client.env = :test
+    client.application_name = 'MyTestAppAfterInit' # Set after initialization
+
+    mock_response = Faraday::Response.new(status: 200, body: '{}')
+
+    mock_conn = instance_double(Faraday::Connection)
+    expect(Faraday).to receive(:new).and_yield(mock_conn).and_return(mock_conn)
+    allow(mock_conn).to receive(:adapter)
+    connection_headers = {}
+    allow(mock_conn).to receive(:headers).and_return(connection_headers)
+
+    expect(mock_conn).to receive(:post) do |&block|
+      mock_req = double('Faraday::Request')
+      allow(mock_req).to receive(:body=)
+      block.call(mock_req) if block_given?
+      mock_response
+    end.and_return(mock_response)
+
+    client.checkout.payments_api.payments({})
+
+    expect(connection_headers['User-Agent']).to_not be_nil
+    expect(connection_headers['User-Agent']).to_not be_empty
+    expect(connection_headers['User-Agent']).to eq("MyTestAppAfterInit #{Adyen::NAME}/#{Adyen::VERSION}")
+  end
+end