✅ add some tests

Author: josemigallas

test/functional/provider/admin/user/access_tokens_controller_test.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+class Provider::Admin::User::AccessTokensControllerTest < ActionController::TestCase
+
+  def setup
+    @provider = FactoryBot.create(:provider_account)
+    @admin = @provider.admins.first
+
+    host! @provider.external_admin_domain
+    login_as @admin
+  end
+
+  test 'index renders the tokens list' do
+    get :index
+
+    assert_response :success
+    assert_template 'index'
+  end
+
+  test 'index renders access_token_created when flash[:token] is set' do
+    token = FactoryBot.create(:access_token, owner: @admin)
+
+    get :index, flash: { token: token.id }
+
+    assert_response :success
+    assert_template 'access_token_created'
+  end
+
+  test 'index falls back to normal index when flash[:token] references a nonexistent token' do
+    get :index, flash: { token: 'nonexistent' }
+
+    assert_response :success
+    assert_template 'index'
+  end
+
+  test 'index does not expose tokens from other users' do
+    other_user = FactoryBot.create(:simple_user, account: @provider)
+    other_token = FactoryBot.create(:access_token, owner: other_user)
+
+    get :index, flash: { token: other_token.id }
+
+    assert_response :success
+    assert_template 'index'
+  end
+end

test/unit/presenters/provider/admin/user/access_tokens_index_presenter_test.rb

@@ -0,0 +1,59 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+class Provider::Admin::User::AccessTokensIndexPresenterTest < ActiveSupport::TestCase
+
+  setup do
+    @provider = FactoryBot.create(:simple_provider)
+  end
+
+  test '#access_tokens returns the user access tokens' do
+    user = FactoryBot.create(:admin, account: @provider)
+    token = FactoryBot.create(:access_token, owner: user)
+    other_token = FactoryBot.create(:access_token)
+
+    presenter = Provider::Admin::User::AccessTokensIndexPresenter.new(user: user)
+
+    access_tokens = presenter.access_tokens
+    assert_includes access_tokens, token
+    assert_not_includes access_tokens, other_token
+  end
+
+  test '#no_allowed_scopes? is true when user has no permissions' do
+    member = FactoryBot.create(:simple_user, account: @provider)
+
+    presenter = Provider::Admin::User::AccessTokensIndexPresenter.new(user: member)
+
+    assert presenter.no_allowed_scopes?
+  end
+
+  test '#no_allowed_scopes? is false when user has relevant permissions' do
+    user = FactoryBot.create(:simple_user, account: @provider)
+    user.stubs(:allowed_access_token_scopes).returns(
+      AccessToken::ScopesFactory.build('Analytics API' => 'stats')
+    )
+
+    presenter = Provider::Admin::User::AccessTokensIndexPresenter.new(user: user)
+
+    assert_not presenter.no_allowed_scopes?
+  end
+
+  test '#service_tokens returns services with tokens for authorized users' do
+    admin = FactoryBot.create(:admin, account: @provider)
+    token = FactoryBot.create(:simple_service, account: @provider).active_service_token
+
+    presenter = Provider::Admin::User::AccessTokensIndexPresenter.new(user: admin)
+
+    assert_includes presenter.service_tokens.map(&:active_service_token), token
+  end
+
+  test '#service_tokens returns empty for users without plans permission' do
+    member = FactoryBot.create(:simple_user, account: @provider)
+    member.stubs(:has_permission?).with(:plans).returns(false)
+
+    presenter = Provider::Admin::User::AccessTokensIndexPresenter.new(user: member)
+
+    assert_empty presenter.service_tokens
+  end
+end