fix(guardian): keep main's per-account endpoint model after UI-revamp rebase; changelog

Author: WiktorStarczewski

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Features
 
+* [FEATURE][all] **v0 UI revamp.** Refreshes the wallet's visual design across onboarding, home, send, receive, and explore: new typography (Inter body, Nunito headings), brand colors, animated progress/segmented bars, a multi-step send flow (recipient → amount → review), a tabbed receive screen (Address / Pending), and shared UI primitives (`AssetRow`, `SearchInput`, `CardItem`). Guardian selection is unified into a reusable `ChooseGuardianScreen` (also used for switch-guardian) backed by a selectable operator list (`GUARDIAN_OPTIONS`). (#248)
 * [FEATURE][extension] **New-wallet onboarding hands off to the Chrome side panel.** When creating a wallet, the final onboarding screen creates it while the tab spins ("Creating your wallet…"); once it's ready, the "Open wallet" button opens the side panel onto the finished wallet and closes the onboarding tab. Creating the wallet first means the panel opens from a live user gesture (Chrome requires one for `sidePanel.open()`) onto an already-functional wallet — no loading state in the panel. The side panel also becomes the primary surface (clicking the toolbar icon opens it instead of the popup — toggle back via the header's maximise-view control). Import flows and non-Chrome browsers keep the classic in-tab flow.
 
 ### Fixes

src/lib/miden/back/vault.gaps.test.ts

@@ -319,13 +319,6 @@ describe('Vault.spawn: Guardian recovery (lookup + adopt)', () => {
     }));
 
     try {
-      // Guardian recovery now reads the endpoint from storage and throws if
-      // missing (DEFAULT_GUARDIAN_ENDPOINT is gone), so seed it like the
-      // onboarding flow does before calling spawn.
-      const { putToStorage } = await import('../front/storage');
-      const { GUARDIAN_URL_STORAGE_KEY } = await import('lib/settings/constants');
-      await putToStorage(GUARDIAN_URL_STORAGE_KEY, 'https://my-guardian.example');
-
       const vault = await Vault.spawn(WalletType.Guardian, 'pw', VALID_MNEMONIC, true);
       expect(vault).toBeInstanceOf(Vault);
     } finally {

src/lib/miden/back/vault.ts

@@ -22,6 +22,7 @@ import {
 } from 'lib/miden/back/safe-storage';
 import * as Passworder from 'lib/miden/passworder';
 import { clearStorage } from 'lib/miden/reset';
+import { DEFAULT_GUARDIAN_ENDPOINT } from 'lib/miden-chain/constants';
 import { isDesktop, isMobile } from 'lib/platform';
 import * as secureHotKey from 'lib/secure-hot-key';
 import { GUARDIAN_URL_STORAGE_KEY } from 'lib/settings/constants';
@@ -384,10 +385,8 @@ export class Vault {
 
       if (isGuardianRecovery) {
         console.log('[Vault.spawn] Step 7a: recovering Guardian accounts (adopt only — rotation deferred)...');
-        const guardianEndpoint = await fetchFromStorage<string>(GUARDIAN_URL_STORAGE_KEY);
-        if (!guardianEndpoint) {
-          throw new Error('Guardian endpoint missing from storage — wallet must complete guardian onboarding first');
-        }
+        const guardianEndpoint =
+          (await fetchFromStorage<string>(GUARDIAN_URL_STORAGE_KEY)) || DEFAULT_GUARDIAN_ENDPOINT;
         const recovered = await midenClient.recoverGuardianAccountsBySeed(
           (idx: number) => deriveClientSeed(WalletType.Guardian, mnemonic!, idx),
           guardianEndpoint

src/lib/miden/front/guardian-manager.test.ts

@@ -42,6 +42,10 @@ jest.mock('lib/miden/guardian', () => ({
   }
 }));
 
+jest.mock('lib/miden-chain/constants', () => ({
+  DEFAULT_GUARDIAN_ENDPOINT: 'https://default.guardian.test'
+}));
+
 jest.mock('lib/settings/constants', () => ({
   GUARDIAN_URL_STORAGE_KEY: 'guardian_url_setting'
 }));
@@ -103,26 +107,23 @@ describe('guardian-manager', () => {
       expect(mockMultisigServiceInit).not.toHaveBeenCalled();
     });
 
-    it('evicts the cached service when storage is empty on the cache-drift re-check', async () => {
+    it('falls back to DEFAULT_GUARDIAN_ENDPOINT when storage is empty on the cache-drift re-check', async () => {
       // First call seeds the cache with a service pinned to the default endpoint.
       const service = { guardianEndpoint: 'https://default.guardian.test', tag: 'cached' };
       mockMultisigServiceInit.mockResolvedValueOnce(service);
       const provider = makeProvider([guardianAccount]);
       await getOrCreateMultisigService(GUARDIAN_PK, provider);
 
-      // Second call: storage returns `undefined`. With DEFAULT_GUARDIAN_ENDPOINT
-      // gone, the cache check requires storage to hold a value — empty storage
-      // is treated as drift, so the entry is evicted and the service is
-      // re-initialized.
-      const refreshed = { guardianEndpoint: 'https://default.guardian.test', tag: 'refreshed' };
+      // Second call: storage returns `undefined`, so the re-check computes the
+      // default endpoint via the `|| DEFAULT_GUARDIAN_ENDPOINT` fallback and
+      // the cached instance stays valid.
       mockFetchFromStorage.mockResolvedValueOnce(undefined);
       mockMultisigServiceInit.mockClear();
-      mockMultisigServiceInit.mockResolvedValueOnce(refreshed);
 
       const second = await getOrCreateMultisigService(GUARDIAN_PK, provider);
 
-      expect(second).toBe(refreshed);
-      expect(mockMultisigServiceInit).toHaveBeenCalledTimes(1);
+      expect(second).toBe(service);
+      expect(mockMultisigServiceInit).not.toHaveBeenCalled();
     });
 
     it('evicts the cached service and reinitializes when the stored guardian URL drifts', async () => {

src/lib/miden/guardian/account.test.ts

@@ -19,6 +19,10 @@ jest.mock('../front/storage', () => ({
   fetchFromStorage: (...args: unknown[]) => mockFetchFromStorage(...args)
 }));
 
+jest.mock('lib/miden-chain/constants', () => ({
+  DEFAULT_GUARDIAN_ENDPOINT: 'https://default.guardian.test'
+}));
+
 jest.mock('lib/settings/constants', () => ({
   GUARDIAN_URL_STORAGE_KEY: 'guardian_url_setting'
 }));
@@ -198,9 +202,7 @@ describe('createGuardianAccount', () => {
   beforeEach(() => {
     jest.clearAllMocks();
     multisigClientConfig.getPubkey.mockResolvedValue({ commitment: 'g-commit', pubkey: 'g-pubkey' });
-    // Storage is the source of truth for the guardian endpoint now — return a
-    // sane value by default so the per-test override paths still work.
-    mockFetchFromStorage.mockResolvedValue('https://stored.guardian');
+    mockFetchFromStorage.mockResolvedValue(undefined);
     mockGenerateHotKey.mockResolvedValue({
       ciphertext: 'hot-ciphertext-hex',
       publicKeyHex: 'hot-pubkey-hex',